Fix sphere vertex sampling: compare squared radius to squared bound#144
Merged
Merged
Conversation
In-sphere rejection sampling compared x*x+y*y+z*z (a squared magnitude) against the un-squared max_radius, so the accepted region had radius sqrt(max_radius) instead of max_radius. Square the bound. The sampling cube already spans [-max_radius, max_radius] per component, so rejection sampling stays valid. Fixes gemc#109 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-sphere rejection sampling compared the squared magnitude
x*x+y*y+z*zagainst the un-squaredmax_radius, so the accepted region had radiussqrt(max_radius)instead ofmax_radius(e.g.max_radius=4accepted only radius 2). This squares the bound. The sampling cube already spans[-max_radius, max_radius]per component, so rejection sampling stays valid.Validation: translation unit recompiled cleanly with Geant4 11.4.1 / ROOT 6.38 / Qt 6.9 (ghcr.io/gemc/src:dev-almalinux-10).
Fixes #109