Guard parseFileAndRemoveComments against a comment before the first newline#146
Merged
Merged
Conversation
…ewline
rfind('\n') returns npos when a comment marker is on the first line, and
erase(npos, ...) throws std::out_of_range. Treat firstNL==npos as "erase
from position 0" and secondNL==npos (comment on the last line, no
trailing newline) as "erase to end".
Fixes gemc#133
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseFileAndRemoveCommentscomputes the newlines around a comment marker and erases between them.rfind('\n')returnsnposwhen the comment is on the first line, anderase(npos, ...)throwsstd::out_of_range. This treatsfirstNL==nposas "erase from position 0" andsecondNL==npos(comment on the last line, no trailing newline) as "erase to end". Behavior for the common middle-of-file case is unchanged.Validation: translation unit recompiled cleanly with Geant4 11.4.1 / ROOT 6.38 / Qt 6.9 (ghcr.io/gemc/src:dev-almalinux-10).
Fixes #133