Guard against null GetVisAttributes() in G4Ttree_item constructor#147
Merged
Merged
Conversation
G4LogicalVolume::GetVisAttributes() returns nullptr for volumes with no vis attributes (e.g. imported CAD/GDML geometries), and the constructor dereferenced it unconditionally, crashing the geometry tree viewer. Add a null check with an opaque-white, visible fallback. Fixes gemc#137 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G4LogicalVolume::GetVisAttributes()returnsnullptrfor volumes with no vis attributes (e.g. imported CAD/GDML geometries), and theG4Ttree_itemconstructor dereferenced it unconditionally for bothGetColour()andIsVisible(), crashing the geometry tree viewer (it builds one item per volume). This adds a null check with an opaque-white, visible fallback.Validation: translation unit recompiled cleanly with Geant4 11.4.1 / ROOT 6.38 / Qt 6.9 (ghcr.io/gemc/src:dev-almalinux-10).
Fixes #137