Skip to content

Guard against null GetVisAttributes() in G4Ttree_item constructor #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maureeungaro merged 1 commit into from
Jun 13, 2026
Merged

Guard against null GetVisAttributes() in G4Ttree_item constructor #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions gemc/gtree/gtree.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,18 +197,18 @@ G4Ttree_item::G4Ttree_item(G4Volume* g4volume, const GVolume* gvolume) {

// Read visualization attributes from the logical volume.
auto visAttributes = lvolume->GetVisAttributes();
auto gcolor = visAttributes->GetColour();

double red = gcolor.GetRed();
double green = gcolor.GetGreen();
double blue = gcolor.GetBlue();
auto alpha = gcolor.GetAlpha();

color = QColor::fromRgbF(red, green, blue);

opacity = alpha;

is_visible = visAttributes->IsVisible();
if (visAttributes != nullptr) {
auto gcolor = visAttributes->GetColour();
color = QColor::fromRgbF(gcolor.GetRed(), gcolor.GetGreen(), gcolor.GetBlue());
opacity = gcolor.GetAlpha();
is_visible = visAttributes->IsVisible();
}
else {
// No vis attributes assigned (e.g. imported CAD/GDML volumes): fall back to opaque white, visible.
color = QColor::fromRgbF(1.0, 1.0, 1.0);
opacity = 1.0;
is_visible = true;
}

// Store scaled physics quantities for display (g, cm3, g/cm3).
mass = lvolume->GetMass(false, true) / (CLHEP::g);
Expand Down