Default-initialize CSV factory's cached event/run/thread ids#149
Merged
Conversation
event_number, runId, and thread_id were declared without initializers. In run mode, publishRunDigitizedDataImpl writes event_number and thread_id directly, but the run path never goes through startEvent or publishEventHeader, so both ints were read uninitialized — undefined behavior emitting garbage into the evn and thread_id columns of every run-mode CSV row. Initialize all three to -1 (matching the JSON factory's fallback convention) so the columns are deterministic. Fixes gemc#128 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event_number,runId, andthread_idinGstreamerCsvFactorywere declared without initializers. In run mode,publishRunDigitizedDataImplwritesevent_numberandthread_iddirectly, but the run path never goes throughstartEvent/publishEventHeader, so both ints were read while uninitialized — undefined behavior, emitting garbage into theevnandthread_idcolumns of every run-mode CSV row.Initialize all three to
-1(matching the JSON factory's fallback convention) so the run-mode columns are deterministic and machine-parseable.Validation: CSV plugin compiles clean (Geant4 11.4.1 dev container).
Fixes #128