Normalize run data once, not once per run streamer#152
Merged
Conversation
publish_run_data called normalize_run_data inside the per-streamer loop. normalize_run_data mutates the shared run_data_collaction in place (replacing each normalized observable with value/events_processed) and is not idempotent, so with two or more run-mode streamers the second streamer published value/N^2, the third value/N^3, and so on. Hoist the normalization out of the loop so it runs exactly once per run regardless of streamer count. Fixes gemc#105 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish_run_datacallednormalize_run_datainside the per-streamer loop.normalize_run_datamutates the sharedrun_data_collactionin place (replacing each normalized observable withvalue/events_processed) and is not idempotent, so with two or more run-mode streamers the second streamer publishedvalue/N², the thirdvalue/N³, and so on.Hoist the normalization out of the loop so it runs exactly once per run regardless of streamer count.
Validation:
gRunAction.cccompiles clean (Geant4 11.4.1 dev container).Fixes #105