Skip to content

Normalize run data once, not once per run streamer #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maureeungaro merged 1 commit into from
Jun 13, 2026
Merged

Normalize run data once, not once per run streamer #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions gemc/actions/run/gRunAction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,15 +256,17 @@ void GRunAction::publish_run_data(const std::shared_ptr<GRunDataCollection> &run
" no run streamer map available - run data will not be published.");
}

// Normalize once, before publishing: normalize_run_data() mutates run_data_collaction
// in place and is NOT idempotent, so running it per streamer would divide the run
// observables by events_processed once for every configured run streamer.
normalize_run_data(run_data_collaction);

for (const auto &[name, gstreamer]: *gstreamer_run_map) {
if (gstreamer == nullptr) {
log->error(ERR_STREAMERMAP_NOT_EXISTING, FUNCTION_NAME,
" null gstreamer instance for run streamer ", name);
}


normalize_run_data(run_data_collaction);

gstreamer->publishRunData(run_data_collaction);
}
}
Expand Down