Do not crash on "gemc help" with no topic#160
Merged
Conversation
The early help handler read argv[i + 1] without a bounds check. For the bare "gemc help" (the natural way to ask for the help index), i + 1 == argc, so argv[argc] (the null terminator) was passed to the std::string parameter of printOptionOrSwitchHelp, throwing std::logic_error and aborting. Bounds-check i + 1 < argc and fall back to printHelp() (which already exists and exits) when no topic follows. Verified: "gemc help" now prints the help index and exits 0 instead of terminating with an uncaught exception (Geant4 11.4.1 dev container). Fixes gemc#121 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The early help handler read
argv[i + 1]without a bounds check. For the baregemc help(the natural way to ask for the help index),i + 1 == argc, soargv[argc](the null terminator) was passed to thestd::stringparameter ofprintOptionOrSwitchHelp, throwingstd::logic_errorand aborting. Bounds-checki + 1 < argcand fall back toprintHelp()(which already exists and exits) when no topic follows.Validation: ran in the Geant4 11.4.1 dev container —
gemc helpnow prints the help index and exits 0 instead of terminating with an uncaught exception.Fixes #121