Correct INSTALL_TARBALL.md: gemc is dynamically linked, not static#163
Closed
zhaozhiwen wants to merge 1 commit into
Closed
Correct INSTALL_TARBALL.md: gemc is dynamically linked, not static#163zhaozhiwen wants to merge 1 commit into
zhaozhiwen wants to merge 1 commit into
Conversation
The generated INSTALL_TARBALL.md claimed "GEMC is statically linked against Geant4," but the packaging step just copies the meson-install binary (no static relink), and that binary dynamically resolves ~30 libG4*.so plus libCLHEP. A user following the doc (source gemc.env, run gemc -v) hits "cannot open shared object file" because no Geant4/CLHEP runtime is bundled or guaranteed on the host. Make the doc match the artifact: state that gemc is dynamically linked against Geant4 and CLHEP and that a matching runtime must be on LD_LIBRARY_PATH (e.g. by sourcing geant4.sh) before running, and note the data files are likewise not bundled. Section header widened to "Geant4 runtime and data". Docs-only change to the packaging heredoc; no packaging behavior changes. Verified: bash -n passes and the heredoc renders the intended markdown (escaped backticks stay literal). Fixes gemc#123 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
GEMC is statically linked to Geant4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated
INSTALL_TARBALL.mdclaimed "GEMC is statically linked against Geant4," but the packaging step (ci/package_install.sh) justcp -as the meson-install tree — no static relink — and that binary dynamically resolves ~30libG4*.sopluslibCLHEP. A user following the doc (source gemc.env,gemc -v) hits "cannot open shared object file" because no Geant4/CLHEP runtime is bundled or guaranteed on the host.Per maintainer direction, this is the docs-only fix (the issue's Option A): make the documentation match the artifact rather than change linking. The text now states gemc is dynamically linked against Geant4 and CLHEP and that a matching runtime must be on
LD_LIBRARY_PATH(e.g. by sourcinggeant4.sh) before running, and notes the data files are likewise not bundled. Section header widened to "Geant4 runtime and data".Docs-only change to the packaging heredoc; no packaging behavior changes.
Validation:
bash -n ci/package_install.shpasses, and rendering the heredoc in isolation produces the intended markdown (escaped backticks stay literal, no command substitution).Fixes #123