Skip to content

Clone the registry GTouchable per step to stop cross-event state leak #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maureeungaro merged 1 commit into from
Jun 13, 2026
Merged

Clone the registry GTouchable per step to stop cross-event state leak #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gemc/gsd/gsd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,9 @@ class GSensitiveDetector : public GBase<GSensitiveDetector>, public G4VSensitive
std::string vname = thisStep->GetPreStepPoint()->GetTouchable()->GetVolume()->GetName();

auto it = gTouchableMap.find(vname);
if (it != gTouchableMap.end()) { return it->second; }
// Return a per-step copy: ProcessHits and processTouchable mutate trackId, pid and the
// time-cell index, so the registry entry must stay pristine across steps and events.
if (it != gTouchableMap.end()) { return std::make_shared<GTouchable>(*it->second); }
// If not found, log an error. The calling code assumes a valid pointer.
log->error(ERR_DYNAMICPLUGINNOTFOUND, "GTouchable for volume " + vname + " not found in gTouchableMap");
}
Expand Down