Add rule-of-five to GFrameDataCollection to prevent double-free#168
Merged
Merged
Conversation
GFrameDataCollection owns three raw pointers (gevent_header, the payload objects, and the heap-allocated payload vector) and deletes them in its destructor, but declared no copy/move operations. The implicitly generated copy/move do a shallow pointer copy, so any copy (stored by value, passed by value, returned pre-elision) would give two owners and double-free on destruction. No active copy site exists today, so this is a latent footgun. Delete copy and move to make the ownership intent explicit and close the hole; the documented long-term fix is unique_ptr members. Verified the deletions don't break the build (nothing copies or moves it). Fixes gemc#136 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GFrameDataCollectionowns three raw pointers (gevent_header, the payload objects, and the heap-allocated payload vector) and deletes them in its destructor, but declared no copy/move operations. The implicitly generated copy/move do a shallow pointer copy, so any copy (stored by value, passed by value, returned pre-elision) would give two owners and double-free on destruction.No active copy site exists today, so this is a latent footgun. Delete copy and move to make the ownership intent explicit and close the hole; the documented long-term fix is
unique_ptrmembers.Validation: rebuilt
gemcin the Geant4 11.4.1 dev container — the deletions compile cleanly, confirming nothing currently copies or moves it.Fixes #136