Conversation
There was a problem hiding this comment.
Code Review
This pull request adds configuration files for Claude Code and Antigravity support and updates the README with detailed installation instructions for various platforms. Feedback includes correcting version inconsistencies across the new JSON files, fixing a typo in the contact email, renaming a placeholder MCP server, and addressing a reference to a missing .mcp.json file.
| 1. Add the Marketplace. | ||
|
|
||
| ```bash | ||
| claude plugin marketplace add https://github.com/gemini-cli-extensions/cicd.git#0.2.2 |
There was a problem hiding this comment.
This cmd is not working as we haven't release 0.2.2 yet:
claude plugin marketplace add https://github.com/gemini-cli-extensions/cicd.git#0.2.2
Adding marketplace…
✘ Failed to add marketplace: Failed to clone marketplace repository: Cloning into '~/.claude/plugins/marketplaces/temp_1776882747054'...
warning: Could not find remote branch 0.2.2 to clone.
fatal: Remote branch 0.2.2 not found in upstream originI'm testing using claude plugin marketplace add https://github.com/gemini-cli-extensions/cicd.git#plugins now and it works fine, just make sure we added the 0.2.2 release after merge this
There was a problem hiding this comment.
I have changed to current released version 0.2.1
There was a problem hiding this comment.
We need to postfix #v0.2.1 instead of #0.2.1. I found the postfix here is either a branch name or a tag name of our repo so we need to be consistent. Another issue is that we did not add .claude-plugin folder under the tag v0.2.1 so it did not work:
# this fails because tag '0.2.1' does not exist, what we have is 'v0.2.1'
$ claude plugin marketplace add https://github.com/gemini-cli-extensions/cicd.git#0.2.1
Adding marketplace…
✘ Failed to add marketplace: Failed to clone marketplace repository: Cloning into '~/.claude/plugins/marketplaces/temp_1776954635843'...
warning: Could not find remote branch 0.2.1 to clone.
fatal: Remote branch 0.2.1 not found in upstream origin
# this fails because we did not put '.claude-plugin' into tag 'v0.2.1'
$ claude plugin marketplace add https://github.com/gemini-cli-extensions/cicd.git#v0.2.1
Adding marketplace…
✘ Failed to add marketplace: Marketplace file not found at ~/.claude/plugins/marketplaces/temp_1776954645535/.claude-plugin/marketplace.jsonI think the best solution here is to keep postfix v0.2.2 (not 0.2.2):
claude plugin marketplace add https://github.com/gemini-cli-extensions/cicd.git#v0.2.2and when we push to main, we release a new version tagged v0.2.2. Let me know what you think.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds configuration files for Claude Code and Antigravity integrations, updates the README with new installation steps, and increments the version to 0.2.2. The review feedback highlights the need for consistent MCP server naming across configuration files and recommends standardizing installation URLs in the documentation for better maintainability.
| 1. Add the Marketplace. | ||
|
|
||
| ```bash | ||
| claude plugin marketplace add https://github.com/gemini-cli-extensions/cicd.git#v0.2.2 |
There was a problem hiding this comment.
This installation command includes a hardcoded version tag (#v0.2.2) and a .git suffix, which differs from the installation URLs provided for Gemini CLI (line 48) and Antigravity (line 80). For better maintainability and consistency, consider using a uniform URL format and avoiding hardcoded version tags in the documentation unless specifically required for a stable release.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Added Claude Code plugin and instructions for manual installation to other agents.