Skip to content

Commit 1adf21a

Browse files
authored
Merge pull request #143 from gemini-cli-extensions/fix/bug-fixes
refactor: Streamline interactive prompts and remove redundant announcements
2 parents 90b583f + ebbfa06 commit 1adf21a

3 files changed

Lines changed: 8 additions & 14 deletions

File tree

commands/conductor/implement.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
117117
b. **Update Product Definition:**
118118
i. **Condition for Update:** Based on your analysis, you MUST determine if the completed feature or bug fix significantly impacts the description of the product itself.
119119
ii. **Propose and Confirm Changes:** If an update is needed:
120-
- **Announce:** Briefly state that updates are proposed. Do NOT repeat the request to review in the chat.
121120
- **Ask for Approval:** Use the `ask_user` tool to request confirmation. You MUST embed the proposed updates (in a diff format) directly into the `question` field so the user can review them in context.
122121
- **questions:**
123122
- **header:** "Product"
@@ -132,7 +131,6 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
132131
c. **Update Tech Stack:**
133132
i. **Condition for Update:** Similarly, you MUST determine if significant changes in the technology stack are detected as a result of the completed track.
134133
ii. **Propose and Confirm Changes:** If an update is needed:
135-
- **Announce:** Briefly state that updates are proposed. Do NOT repeat the request to review in the chat.
136134
- **Ask for Approval:** Use the `ask_user` tool to request confirmation. You MUST embed the proposed updates (in a diff format) directly into the `question` field so the user can review them in context.
137135
- **questions:**
138136
- **header:** "Tech Stack"
@@ -148,7 +146,6 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
148146
i. **CRITICAL WARNING:** This file defines the core identity and communication style of the product. It should be modified with extreme caution and ONLY in cases of significant strategic shifts, such as a product rebrand or a fundamental change in user engagement philosophy. Routine feature updates or bug fixes should NOT trigger changes to this file.
149147
ii. **Condition for Update:** You may ONLY propose an update to this file if the track's **Specification** explicitly describes a change that directly impacts branding, voice, tone, or other core product guidelines.
150148
iii. **Propose and Confirm Changes:** If the conditions are met:
151-
- **Announce:** Briefly state that updates are proposed. Do NOT repeat the request to review in the chat.
152149
- **Ask for Approval:** Use the `ask_user` tool to request confirmation. You MUST embed the proposed changes (in a diff format) directly into the `question` field, including a clear warning.
153150
- **questions:**
154151
- **header:** "Product"

commands/conductor/newTrack.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
8080
3. **Draft `spec.md`:** Once sufficient information is gathered, draft the content for the track's `spec.md` file, including sections like Overview, Functional Requirements, Non-Functional Requirements (if any), Acceptance Criteria, and Out of Scope.
8181
8282
4. **User Confirmation:**
83-
- **Announce:** Briefly state that the draft is ready (e.g., "Draft generated."). Do NOT repeat the request to "review" or "approve" in the chat.
8483
- **Ask for Approval:** Use the `ask_user` tool to request confirmation. You MUST embed the drafted content directly into the `question` field so the user can review it in context.
8584
- **questions:**
8685
- **header:** "Confirm Spec"
@@ -113,7 +112,6 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
113112
* **CRITICAL: Inject Phase Completion Tasks.** Determine if a "Phase Completion Verification and Checkpointing Protocol" is defined in the **Workflow**. If this protocol exists, then for each **Phase** that you generate in `plan.md`, you MUST append a final meta-task to that phase. The format for this meta-task is: `- [ ] Task: Conductor - User Manual Verification '<Phase Name>' (Protocol in workflow.md)`.
114113
115114
3. **User Confirmation:**
116-
- **Announce:** Briefly state that the draft is ready (e.g., "Draft generated."). Do NOT repeat the request to "review" or "approve" in the chat.
117115
- **Ask for Approval:** Use the `ask_user` tool to request confirmation. You MUST embed the drafted content directly into the `question` field so the user can review it in context.
118116
- **questions:**
119117
- **header:** "Confirm Plan"

commands/conductor/setup.toml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
2323
## 1.2 PROJECT AUDIT
2424
**PROTOCOL: Before starting the setup, determine the project's state by auditing existing artifacts.**
2525
26-
1. **Audit Artifacts:** Check the file system for the existence of the following files/directories in the `conductor/` directory:
26+
1. **Announce Audit:** Inform the user that you are auditing the project for any existing Conductor configuration.
27+
28+
2. **Audit Artifacts:** Check the file system for the existence of the following files/directories in the `conductor/` directory:
2729
- `product.md`
2830
- `product-guidelines.md`
2931
- `tech-stack.md`
@@ -32,7 +34,7 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
3234
- `index.md`
3335
- `tracks/*/` (specifically `plan.md` and `index.md`)
3436
35-
2. **Determine Target Section:** Map the project's state to a target section using the priority table below (highest match wins). **DO NOT JUMP YET.** Keep this target in mind.
37+
3. **Determine Target Section:** Map the project's state to a target section using the priority table below (highest match wins). **DO NOT JUMP YET.** Keep this target in mind.
3638
3739
| Artifact Exists | Target Section | Announcement |
3840
| :--- | :--- | :--- |
@@ -45,7 +47,7 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
4547
| `product.md` | **Section 2.2** | "Resuming setup: Product Guide is complete. Next: create Product Guidelines." |
4648
| (None) | **Section 2.0** | (None) |
4749
48-
3. **Proceed to Section 2.0:** You MUST proceed to Section 2.0 to establish the Greenfield/Brownfield context before jumping to your target.
50+
4. **Proceed to Section 2.0:** You MUST proceed to Section 2.0 to establish the Greenfield/Brownfield context before jumping to your target.
4951
5052
---
5153
@@ -158,10 +160,9 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
158160
- **If user chose "Autogenerate":** Use your best judgment to expand on the initial project goal and infer any missing details to create a comprehensive document.
159161
- **If user chose "Interactive":** Use the specific answers provided. The source of truth is **only the user's selected answer(s)**. You are encouraged to expand on these choices to create a polished output.
160162
5. **User Confirmation Loop:**
161-
- **Announce:** Briefly state that the draft is ready (e.g., "Draft generated."). Do NOT repeat the request to "review" or "approve" in the chat.
162163
- **Ask for Approval:** Use the `ask_user` tool to request confirmation. You MUST embed the drafted content directly into the `question` field so the user can review it in context.
163164
- **questions:**
164-
- **header:** "Review"
165+
- **header:** "Review Draft"
165166
- **question:**
166167
Please review the drafted Product Guide below. What would you like to do next?
167168
@@ -206,10 +207,9 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
206207
- **If user chose "Autogenerate":** Use your best judgment to infer standard, high-quality guidelines suitable for the project type.
207208
- **If user chose "Interactive":** Use the specific answers provided. The source of truth is **only the user's selected answer(s)**. You are encouraged to expand on these choices to create a polished output.
208209
5. **User Confirmation Loop:**
209-
- **Announce:** Briefly state that the draft is ready (e.g., "Draft generated."). Do NOT repeat the request to "review" or "approve" in the chat.
210210
- **Ask for Approval:** Use the `ask_user` tool to request confirmation. You MUST embed the drafted content directly into the `question` field so the user can review it in context.
211211
- **questions:**
212-
- **header:** "Review"
212+
- **header:** "Review Draft"
213213
- **question:**
214214
Please review the drafted Product Guidelines below. What would you like to do next?
215215
@@ -262,10 +262,9 @@ CRITICAL: You must validate the success of every tool call. If any tool call fai
262262
- **If user chose "Autogenerate":** Use your best judgment to infer a standard, high-quality stack suitable for the project goal.
263263
- **If user chose "Interactive" or corrected the Brownfield stack:** Use the specific answers provided. The source of truth is **only the user's selected answer(s)**.
264264
5. **User Confirmation Loop:**
265-
- **Announce:** Briefly state that the draft is ready (e.g., "Draft generated."). Do NOT repeat the request to "review" or "approve" in the chat.
266265
- **Ask for Approval:** Use the `ask_user` tool to request confirmation. You MUST embed the drafted content directly into the `question` field so the user can review it in context.
267266
- **questions:**
268-
- **header:** "Review"
267+
- **header:** "Review Draft"
269268
- **question:**
270269
Please review the drafted Tech Stack below. What would you like to do next?
271270

0 commit comments

Comments
 (0)