Skip to content

Commit ec191f0

Browse files
committed
Refactor: Address review comments on PR #93
1 parent f6e909a commit ec191f0

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

KNOWLEDGE_CATALOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ This section covers connecting to a Knowledge Catalog instance.
1414

1515
1. **Verify Environment Variables**: The extension requires the following environment variables to be set before the Gemini CLI is started:
1616

17-
* `DATAPLEX_PROJECT`: The GCP project ID.
17+
* `KNOWLEDGE_CATALOG_PROJECT`: The GCP project ID.
1818

19-
2. **Handle Missing Variables**: If a command fails with an error message containing a placeholder like `${DATAPLEX_PROJECT}`, it signifies a missing environment variable. Inform the user which variable is missing and instruct them to set it.
19+
2. **Handle Missing Variables**: If a command fails with an error message containing a placeholder like `${KNOWLEDGE_CATALOG_PROJECT}`, it signifies a missing environment variable. Inform the user which variable is missing and instruct them to set it.
2020

2121
3. **Handle Permission Errors**: If you encounter permission errors, ensure the user has the correct Knowledge Catalog permissions:
2222
* Dataplex Reader (`roles/dataplex.viewer`) to search and look up entries.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ gemini extensions install https://github.com/gemini-cli-extensions/knowledge-cat
4646

4747
You will be prompted to configure the following settings during installation. These settings are saved in an `.env` file within the extension's directory.
4848

49-
* `DATAPLEX_PROJECT`: The GCP project ID.
49+
* `KNOWLEDGE_CATALOG_PROJECT`: The GCP project ID.
5050

5151
To view or update your configuration:
5252

@@ -63,7 +63,7 @@ To view or update your configuration:
6363
Alternatively, you can manually set these environment variables before starting the Gemini CLI:
6464

6565
```bash
66-
export DATAPLEX_PROJECT="<your-gcp-project-id>"
66+
export KNOWLEDGE_CATALOG_PROJECT="<your-gcp-project-id>"
6767
```
6868

6969
> [!NOTE]

gemini-extension.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
{
1818
"name": "Project ID",
1919
"description": "ID of the Google Cloud project",
20-
"envVar": "DATAPLEX_PROJECT"
20+
"envVar": "KNOWLEDGE_CATALOG_PROJECT"
2121
}
2222
]
2323
}

0 commit comments

Comments
 (0)