fix: update run_poc signature to take in a file path instead of source code to run.

Author: QuinnDACollins

mcp-server/src/index.ts

@@ -56,9 +56,9 @@ server.tool(
   'run_poc',
   'Runs the generated PoC code.',
   {
-    code: z.string().describe('The PoC code to run.'),
+    filePath: z.string().describe('The absolute path to the PoC file to run.'),
   } as any,
-  (input: { code: string }) => runPoc(input)
+  (input: { filePath: string }) => runPoc(input)
 );
 
 server.registerPrompt(

mcp-server/src/poc.test.ts

@@ -8,44 +8,48 @@ import { describe, it, vi, expect } from 'vitest';
 import { runPoc } from './poc.js';
 
 describe('runPoc', () => {
-  it('should write file and execute it', async () => {
-    const mockFs = {
-      mkdir: vi.fn(async () => undefined),
-      writeFile: vi.fn(async () => undefined),
-    };
+  it('should execute the file at the given path', async () => {
     const mockPath = {
-      join: (...args: string[]) => args.join('/'),
+      dirname: (p: string) => p.substring(0, p.lastIndexOf('/')),
     };
-    const mockExecAsync = vi.fn(async () => ({ stdout: 'output', stderr: '' }));
+    const mockExecAsync = vi.fn(async (cmd: string) => {
+      if (cmd.startsWith('npm install')) {
+        return { stdout: '', stderr: '' };
+      }
+      return { stdout: 'output', stderr: '' };
+    });
 
     const result = await runPoc(
-      { code: 'console.log("test")' },
-      { fs: mockFs as any, path: mockPath as any, execAsync: mockExecAsync as any }
+      { filePath: '/tmp/test.js' },
+      { fs: {} as any, path: mockPath as any, execAsync: mockExecAsync as any }
     );
 
-    expect(mockFs.mkdir).toHaveBeenCalledTimes(1);
-    expect(mockFs.writeFile).toHaveBeenCalledTimes(1);
     expect(mockExecAsync).toHaveBeenCalledTimes(2);
+    expect(mockExecAsync).toHaveBeenNthCalledWith(
+      1,
+      'npm install --registry=https://registry.npmjs.org/',
+      { cwd: '/tmp' }
+    );
+    expect(mockExecAsync).toHaveBeenNthCalledWith(2, 'node /tmp/test.js');
     expect((result.content[0] as any).text).toBe(
       JSON.stringify({ stdout: 'output', stderr: '' })
     );
   });
 
   it('should handle execution errors', async () => {
-    const mockFs = {
-      mkdir: vi.fn(async () => undefined),
-      writeFile: vi.fn(async () => undefined),
-    };
     const mockPath = {
-      join: (...args: string[]) => args.join('/'),
+      dirname: (p: string) => p.substring(0, p.lastIndexOf('/')),
     };
-    const mockExecAsync = vi.fn(async () => {
-      throw new Error('Execution failed');
+    const mockExecAsync = vi.fn(async (cmd: string) => {
+      if (cmd.startsWith('node')) {
+        throw new Error('Execution failed');
+      }
+      return { stdout: '', stderr: '' };
     });
 
     const result = await runPoc(
-      { code: 'error' },
-      { fs: mockFs as any, path: mockPath as any, execAsync: mockExecAsync as any }
+      { filePath: '/tmp/error.js' },
+      { fs: {} as any, path: mockPath as any, execAsync: mockExecAsync as any }
     );
 
     expect(result.isError).toBe(true);

mcp-server/src/poc.ts

@@ -14,34 +14,22 @@ const execAsync = promisify(exec);
 
 export async function runPoc(
   {
-    code,
+    filePath,
   }: {
-    code: string;
+      filePath: string;
   },
   dependencies: { fs: typeof fs; path: typeof path; execAsync: typeof execAsync } = { fs, path, execAsync }
 ): Promise<CallToolResult> {
   try {
-    const CWD = process.cwd();
-    const securityDir = dependencies.path.join(CWD, '.gemini_security');
+    const pocDir = dependencies.path.dirname(filePath);
 
-    // Ensure .gemini_security directory exists
     try {
-      await dependencies.fs.mkdir(securityDir, { recursive: true });
-    } catch (error) {
-      // Ignore error if directory already exists
-    }
-
-    const pocFilePath = dependencies.path.join(securityDir, 'poc.js');
-    await dependencies.fs.writeFile(pocFilePath, code, 'utf-8');
-
-
-    try {
-      await dependencies.execAsync('npm install --registry=https://registry.npmjs.org/', { cwd: securityDir });
+      await dependencies.execAsync('npm install --registry=https://registry.npmjs.org/', { cwd: pocDir });
     } catch (error) {
       // Ignore errors from npm install, as it might fail if no package.json exists,
       // but we still want to attempt running the PoC.
     }
-    const { stdout, stderr } = await dependencies.execAsync(`node ${pocFilePath}`);
+    const { stdout, stderr } = await dependencies.execAsync(`node ${filePath}`);
 
     return {
       content: [