cleanup from non clear terms and broken links#10
Merged
Conversation
Contributor
|
🤖 Hi @SzymonSt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This Pull Request successfully cleans up Google-specific internal terminology and broken links across the repository, aligning with the project's security and public-facing standards. The changes are minor but important for maintaining the codebase's integrity and adherence to the GEMINI.md mandates.
🔍 General Feedback
- Changelog Updates: Per
GEMINI.md, all changes should be accompanied by updates toCHANGELOG.md(both root and skill-specific where applicable). Please ensure these are bumped as needed. - Skill Standards:
skills/postmortem-generator-copy/is currently missing aCHANGELOG.mdfile; while this is an existing issue, consider adding one to comply withSKILLS-STANDARDS.md. - Consistency: The removal of restricted terms is thorough for the sections modified, ensuring no internal-only information remains in those locations.
| ## References | ||
|
|
||
| - [GCP Documentation](https://cloud.google.com/docs) | ||
| - [SRE Google Extension Migration Plan](../../docs/migration_plan/README.md) |
Contributor
There was a problem hiding this comment.
🟢 Correctly removes a broken link to a missing migration plan document.
|
|
||
| Check `CONTRIBUTING.md`. | ||
|
|
||
| **Googlers**: See more in `go/SRE-Extension` <!-- pre-publish-checker: ignore --> |
Contributor
There was a problem hiding this comment.
🟢 This removal correctly adheres to the mandate in GEMINI.md to exclude Google-only information. It also removes the pre-publish-checker override. Consider also removing the redundant blank lines to keep the file clean.
| * Feel free to abort if user is unable to provide tools or content for you to build the PM. | ||
| * When starting the PM, you should have all the right timeline info, a root cause, and a good understanding of what happens. | ||
| * Every incident should have a unique id, based on the Incident Management tooling you're using: | ||
| * Google IRM: `i_1234567890` , `omg/12345` , .. |
Contributor
There was a problem hiding this comment.
🟢 This removal correctly adheres to the mandate in GEMINI.md to exclude Google-only information (IRM, omg).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.