chore: split typescript into its own dependabot group#303
Merged
Conversation
TypeScript major version bumps can have peer dependency conflicts with eslint plugins and other tooling. Splitting it into its own group prevents it from blocking unrelated dependency updates.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Dependabot configuration to group TypeScript dependencies. Feedback indicates that the additions to the workspace-server section are redundant and introduce a duplicate group name conflict that needs to be resolved.
…ot config The workspace-server/package.json doesn't list typescript as a dependency, so the group wouldn't match anything. The root-level typescript group already handles it.
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Dependabot configuration to separate 'typescript' dependency updates into a dedicated group. The review feedback suggests a more idiomatic and maintainable approach by reordering the groups so that the specific 'typescript' group is defined before the catch-all 'npm-root' group, which removes the need for explicit exclusion patterns.
Placing the specific typescript group before the npm-root wildcard group eliminates the need for exclude-patterns and is more maintainable when adding future specific groups.
abhipatel12
approved these changes
Mar 31, 2026
Sum1cares
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescriptinto its own dependabot group for both npm ecosystems (root and workspace-server)This was prompted by #293 where TypeScript 6.0.2 had a peer dependency conflict with
@typescript-eslint/eslint-plugin(which requirestypescript <6.0.0), causing the entire grouped PR to fail CI.Test plan