fix: run suite button should only launch visible tests (#747)

Author: shadowusr

lib/static/new-ui/components/TreeViewItemTitle/index.tsx

@@ -7,7 +7,7 @@ import {useDispatch, useSelector} from 'react-redux';
 import {getToggledCheckboxState, isCheckboxChecked, isCheckboxIndeterminate} from '@/common-utils';
 import {EntityType, TreeViewItemData} from '@/static/new-ui/features/suites/components/SuitesPage/types';
 import {toggleBrowserCheckbox, toggleGroupCheckbox, toggleSuiteCheckbox, thunkRunSuite} from '@/static/modules/actions';
-import {getAreCheckboxesNeeded, getBrowsers, getSuites} from '@/static/new-ui/store/selectors';
+import {getAreCheckboxesNeeded, getBrowsers, getBrowsersState, getSuites} from '@/static/new-ui/store/selectors';
 import {getItemCheckStatus} from '@/static/new-ui/components/TreeViewItemTitle/selectors';
 import {ClipboardButton} from '@/static/new-ui/components/ClipboardButton';
 import {RunTestsFeature} from '@/constants';
@@ -19,21 +19,28 @@ interface TreeViewItemTitleProps {
     item: TreeViewItemData;
 }
 
-const getSuiteBrowsers = (suiteId: string, suites: Record<string, {suiteIds?: string[]; browserIds?: string[]}>, browsers: Record<string, {parentId: string; name: string}>): TestSpec[] => {
+const getVisibleSuiteBrowsers = (
+    suiteId: string,
+    suites: Record<string, {suiteIds?: string[]; browserIds?: string[]}>,
+    browsers: Record<string, {parentId: string; name: string}>,
+    browsersState: Record<string, {shouldBeShown: boolean}>
+): TestSpec[] => {
     const suite = suites[suiteId];
     if (!suite) {
         return [];
     }
 
     if (suite.browserIds) {
-        return suite.browserIds.map(browserId => {
-            const browser = browsers[browserId];
-            return {testName: browser.parentId, browserName: browser.name};
-        });
+        return suite.browserIds
+            .filter(browserId => browsersState[browserId]?.shouldBeShown)
+            .map(browserId => {
+                const browser = browsers[browserId];
+                return {testName: browser.parentId, browserName: browser.name};
+            });
     }
 
     if (suite.suiteIds) {
-        return suite.suiteIds.flatMap(childSuiteId => getSuiteBrowsers(childSuiteId, suites, browsers));
+        return suite.suiteIds.flatMap(childSuiteId => getVisibleSuiteBrowsers(childSuiteId, suites, browsers, browsersState));
     }
 
     return [];
@@ -48,13 +55,14 @@ export function TreeViewItemTitle({item}: TreeViewItemTitleProps): React.JSX.Ele
 
     const suites = useSelector(getSuites);
     const browsers = useSelector(getBrowsers);
+    const browsersState = useSelector(getBrowsersState);
     const isRunning = useSelector(state => state.running);
     const isRunTestsAvailable = useSelector(state => state.app.availableFeatures)
         .find(feature => feature.name === RunTestsFeature.name);
 
     const getTestsToRun = (): TestSpec[] => {
         if (item.entityType === EntityType.Suite) {
-            return getSuiteBrowsers(item.entityId, suites, browsers);
+            return getVisibleSuiteBrowsers(item.entityId, suites, browsers, browsersState);
         } else if (item.entityType === EntityType.Browser) {
             // On visual checks page, browserId is stored separately from entityId
             const browserId = item.browserId || item.entityId;
@@ -65,10 +73,12 @@ export function TreeViewItemTitle({item}: TreeViewItemTitleProps): React.JSX.Ele
         } else if (item.entityType === EntityType.Group) {
             const group = groups[item.entityId];
             if (group) {
-                return group.browserIds.map(browserId => {
-                    const browser = browsers[browserId];
-                    return {testName: browser.parentId, browserName: browser.name};
-                });
+                return group.browserIds
+                    .filter(browserId => browsersState[browserId]?.shouldBeShown)
+                    .map(browserId => {
+                        const browser = browsers[browserId];
+                        return {testName: browser.parentId, browserName: browser.name};
+                    });
             }
         }
         return [];

test/func/tests/common-gui/tree-view-actions.testplane.js

@@ -79,6 +79,44 @@ describe('GUI mode', () => {
             expect(attempts.length).toBe(2);
         });
 
+        it('should run only visible tests in suite', async ({browser}) => {
+            const searchInput = await browser.$('[data-qa="name-filter"] input');
+            await searchInput.setValue('test with no reference image');
+            await browser.pause(500);
+
+            const suiteItem = await browser.$('[data-list-item="tests to run"]');
+            await suiteItem.moveTo();
+
+            const runButton = await suiteItem.$('button[title="Run tests"]');
+            await runButton.waitForClickable();
+            await runButton.click();
+
+            await browser.waitUntil(async () => {
+                const spinners = await browser.$$('.g-spin');
+                return spinners.length > 0;
+            }, {timeout: 5000, timeoutMsg: 'Tests did not start running'});
+
+            await browser.waitUntil(async () => {
+                const spinners = await browser.$$('.g-spin');
+                return spinners.length === 0;
+            }, {timeout: 30000, timeoutMsg: 'Tests did not complete'});
+
+            await browser.$('[data-qa="clear-name-filter"]').click();
+            await browser.pause(500);
+
+            const firstTest = await browser.$('[data-list-item*="test with image comparison diff"][data-list-item*="chrome"]');
+            await firstTest.click();
+            await browser.$('[data-qa="suite-title-counter"]').waitForDisplayed();
+            let attempts = await browser.$$('[data-qa="retry-switcher"]');
+            expect(attempts.length).toBe(1);
+
+            const secondTest = await browser.$('[data-list-item*="test with no reference image"][data-list-item*="chrome"]');
+            await secondTest.click();
+            await browser.$('[data-qa="suite-title-counter"]').waitForDisplayed();
+            attempts = await browser.$$('[data-qa="retry-switcher"]');
+            expect(attempts.length).toBe(2);
+        });
+
         it('should run test on visual checks page via run button click', async ({browser}) => {
             await browser.keys('v');