Skip to content

Commit 8d1cfb6

Browse files
author
rocketraccoon
committed
fix: time travel mode
1 parent 4cc65fd commit 8d1cfb6

4 files changed

Lines changed: 18 additions & 8 deletions

File tree

lib/adapters/tool/testplane/test-results-handler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const handleTestResults = (testplane: TestplaneWithHtmlReporter, reportBu
6262
reportPath: testplane.htmlReporter.config.path,
6363
events: testplane.events,
6464
eventName,
65-
timeTravelConfig: testplane.config.timeTravel,
65+
timeTravelConfig: testplane.config.browsers[formattedResultWithoutAttempt.browserId].timeTravel,
6666
snapshotsSaver: testplane.htmlReporter.snapshotsSaver
6767
});
6868

test/unit/lib/adapters/tool/testplane/test-results-handler.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ describe('lib/adapters/tool/testplane/test-results-handler', () => {
2323
AFTER_TESTS_READ: 'afterTestsRead'
2424
};
2525

26-
const mkTestplane_ = () => stubTool(stubConfig(), events);
26+
const mkTestplane_ = () => stubTool(stubConfig({
27+
browsers: {
28+
'some-browser': {}
29+
}
30+
}), events);
2731

2832
const mkTestplaneTestResult = (opts = {}) => _.defaults(opts, {
2933
fullTitle: () => 'some-title',

test/unit/testplane.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@ describe('lib/testplane', () => {
4545
rootUrl: 'browser/root/url',
4646
getAbsoluteUrl: _.noop
4747
}),
48+
browsers: {
49+
bro1: {
50+
timeTravel: 'off'
51+
}
52+
},
4853
getBrowserIds: () => ['bro1']
4954
}, events, {ImageDiffError, NoRefImageError});
5055
}
@@ -203,15 +208,15 @@ describe('lib/testplane', () => {
203208

204209
it('should add skipped test to result', async () => {
205210
await initReporter_();
206-
testplane.emit(events.TEST_PENDING, mkStubResult_({title: 'some-title'}));
211+
testplane.emit(events.TEST_PENDING, mkStubResult_({title: 'some-title', browserId: 'bro1'}));
207212
await testplane.emitAsync(testplane.events.RUNNER_END);
208213

209214
assert.deepEqual(StaticReportBuilder.prototype.addTestResult.args[0][0].state, {name: 'some-title'});
210215
});
211216

212217
it('should add passed test to result', async () => {
213218
await initReporter_();
214-
testplane.emit(events.TEST_PASS, mkStubResult_({title: 'some-title'}));
219+
testplane.emit(events.TEST_PASS, mkStubResult_({title: 'some-title', browserId: 'bro1'}));
215220
await testplane.emitAsync(testplane.events.RUNNER_END);
216221

217222
assert.deepEqual(StaticReportBuilder.prototype.addTestResult.args[0][0].state, {name: 'some-title'});
@@ -220,7 +225,7 @@ describe('lib/testplane', () => {
220225
['TEST_FAIL', 'RETRY'].forEach((event) => {
221226
describe('should add', () => {
222227
it(`errored test to result on ${event} event`, async () => {
223-
const testResult = mkStubResult_({title: 'some-title', stateName: 'state-name'});
228+
const testResult = mkStubResult_({title: 'some-title', browserId: 'bro1', stateName: 'state-name'});
224229
await initReporter_();
225230

226231
testplane.emit(events[event], testResult);
@@ -234,7 +239,7 @@ describe('lib/testplane', () => {
234239
const err = new Error();
235240
err.stateName = 'state-name';
236241

237-
testplane.emit(events[event], mkStubResult_({title: 'some-title', assertViewResults: [err]}));
242+
testplane.emit(events[event], mkStubResult_({title: 'some-title', browserId: 'bro1', assertViewResults: [err]}));
238243
await testplane.emitAsync(testplane.events.RUNNER_END);
239244

240245
assert.deepEqual(StaticReportBuilder.prototype.addTestResult.args[0][0].state, {name: 'some-title'});
@@ -247,6 +252,7 @@ describe('lib/testplane', () => {
247252
err.stateName = 'state-name';
248253
const testResult = mkStubResult_({
249254
title: 'some-title',
255+
browserId: 'bro1',
250256
assertViewResults: [err]
251257
});
252258

@@ -262,7 +268,7 @@ describe('lib/testplane', () => {
262268
const err = new ImageDiffError();
263269
err.stateName = 'state-name';
264270

265-
testplane.emit(events[event], mkStubResult_({title: 'some-title', assertViewResults: [err]}));
271+
testplane.emit(events[event], mkStubResult_({title: 'some-title', browserId: 'bro1', assertViewResults: [err]}));
266272
await testplane.emitAsync(testplane.events.RUNNER_END);
267273

268274
assert.deepEqual(StaticReportBuilder.prototype.addTestResult.args[0][0].state, {name: 'some-title'});

testplane.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ async function handleTestResults(testplane: TestplaneWithHtmlReporter, reportBui
145145
testResult: formattedResult,
146146
attempt,
147147
reportPath: testplane.htmlReporter.config.path,
148-
timeTravelConfig: testplane.config.timeTravel,
148+
timeTravelConfig: testplane.config.browsers[formattedResult.browserId].timeTravel,
149149
events: testplane.events,
150150
eventName,
151151
snapshotsSaver: testplane.htmlReporter.snapshotsSaver

0 commit comments

Comments
 (0)