Skip to content

Commit eadd306

Browse files
authored
fix: handle missing badges list (#762)
1 parent 9de91b5 commit eadd306

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/report-builder/static.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export class StaticReportBuilder {
132132
if (typeof this._reporterConfig.generateBadges === 'function' && testResultWithImagePaths.attachments) {
133133
testResultWithImagePaths.attachments.push({
134134
type: AttachmentType.Badges,
135-
list: this._reporterConfig.generateBadges(testResultWithImagePaths)?.filter((badge) => badge && badge.title) as Badge[]
135+
list: this._reporterConfig.generateBadges(testResultWithImagePaths)?.filter((badge): badge is Badge => Boolean(badge && badge.title))
136136
});
137137
}
138138

lib/static/new-ui/features/suites/components/TestStatusBar/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export const TestStatusBar = (): ReactNode => {
4343
{getSuiteDuration(suite)}
4444
</div>
4545
</div>
46-
{(badges && badges.list.length > 0) && (
46+
{(badges?.list && badges.list.length > 0) && (
4747
<div className={styles['test-status-bar__badges']} data-qa="suite-badges">
4848
{badges.list.map((badge: BadgeType) => (
4949
<Badge

lib/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ export interface SnapshotAttachment {
338338

339339
export interface BadgesAttachment {
340340
type: AttachmentType.Badges;
341-
list: Badge[];
341+
list?: Badge[];
342342
}
343343

344344
export interface TagsAttachment {

0 commit comments

Comments
 (0)