fix: html-reporter gui playwright test launch (step.startTime.getTime)#646
Merged
Conversation
KuznetsovRoman
commented
Apr 2, 2025
| [TestStepKey.Args]: [], | ||
| [TestStepKey.IsFailed]: Boolean(step.error), | ||
| [TestStepKey.TimeStart]: step.startTime.getTime(), | ||
| [TestStepKey.TimeStart]: step.startTime instanceof Date ? step.startTime.getTime() : new Date(step.startTime).getTime(), |
Member
Author
There was a problem hiding this comment.
When launched via "npx playwright test", its intance of Date.
When launched via "npx html-reporter --tool playwright", its ISO string
DudaGod
approved these changes
Apr 2, 2025
| })]; | ||
|
|
||
| assert.deepEqual(adapter.history, expectedHistory); | ||
| }); |
Member
There was a problem hiding this comment.
the test differs from the previous one only by the field startTime. It seems we can get rid of duplication by using forEach
Member
Author
There was a problem hiding this comment.
as those are just 2 tests, i think its more readable that way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.