Merge pull request #96 from gemini-testing/fix/create_diff_image/off_by_one

KuznetsovRoman · web-flow · commit 16b6f4f92061 · 2023-09-27T11:15:59.000+03:00
fix: createDiffImage off by one
diff --git a/lib/utils.js b/lib/utils.js
@@ -143,7 +143,7 @@ exports.calcDiffImage = async (img1, img2, comparator, {highlightColor, shouldCl
 
     for (let y = 0; y < maxHeight; y++) {
         for (let x = 0; x < maxWidth; x++) {
-            if (y > minHeight || x > minWidth) {
+            if (y >= minHeight || x >= minWidth) {
                 markDiff(x, y); // Out of bounds pixels considered as diff
                 continue;
             }

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ exports.calcDiffImage = async (img1, img2, comparator, {highlightColor, shouldCl`
`143`	`143`
`144`	`144`	`for (let y = 0; y < maxHeight; y++) {`
`145`	`145`	`for (let x = 0; x < maxWidth; x++) {`
`146`		`- if (y > minHeight \|\| x > minWidth) {`
	`146`	`+ if (y >= minHeight \|\| x >= minWidth) {`
`147`	`147`	`markDiff(x, y); // Out of bounds pixels considered as diff`
`148`	`148`	`continue;`
`149`	`149`	`}`