perf: remove extra logic from new-browser

Author: KuznetsovRoman

src/browser/history/callstack.ts

@@ -65,11 +65,15 @@ export class Callstack {
         }
     }
 
+    clear(): void {
+        this._stack = [];
+        this._history = [];
+    }
+
     release(): TestStep[] {
         const history = this._history;
 
-        this._stack = [];
-        this._history = [];
+        this.clear();
 
         return history;
     }

src/browser/new-browser.ts

@@ -8,7 +8,6 @@ import type { Capabilities, Options } from "@testplane/wdio-types";
 
 import { Browser, BrowserOpts } from "./browser";
 import signalHandler from "../signal-handler";
-import { runGroup } from "./history";
 import { warn } from "../utils/logger";
 import { getNormalizedBrowserName } from "../utils/browser";
 import { getInstance } from "../config/runtime-config";
@@ -73,23 +72,9 @@ export class NewBrowser extends Browser {
     async init(): Promise<NewBrowser> {
         this._session = await this._createSession();
 
-        this._extendStacktrace();
-        this._addSteps();
-        this._addHistory();
-
-        await runGroup(
-            {
-                session: this._session,
-                callstack: this._callstackHistory!,
-                config: this._config,
-            },
-            "testplane: init browser",
-            async () => {
-                this._addCommands();
-                this.restoreHttpTimeout();
-                await this._setPageLoadTimeout();
-            },
-        );
+        this._addCommands();
+        this.restoreHttpTimeout();
+        await this._setPageLoadTimeout();
 
         return this;
     }
@@ -158,9 +143,7 @@ export class NewBrowser extends Browser {
         }
 
         const fullSessionOpts = Object.assign(sessionOpts!, thirdPartyGridCustomOptions);
-        const sessionPromise = WebDriver.newSession(fullSessionOpts).then(res => {
-            return res;
-        });
+        const sessionPromise = WebDriver.newSession(fullSessionOpts);
 
         const session = await sessionPromise;
 

test/src/browser/history/index.js

@@ -4,7 +4,7 @@ const webdriver = require("@testplane/webdriver");
 const webdriverio = require("@testplane/webdriverio");
 const proxyquire = require("proxyquire");
 const { Callstack } = require("../../../../src/browser/history/callstack");
-const { mkNewBrowser_, mkExistingBrowser_, mkSessionStub_, createBrowserConfig_ } = require("../utils");
+const { mkExistingBrowser_, mkSessionStub_, createBrowserConfig_ } = require("../utils");
 
 describe("commands-history", () => {
     const sandbox = sinon.createSandbox();
@@ -206,28 +206,14 @@ describe("commands-history", () => {
                 sandbox.stub(webdriverio, "remote").resolves(mkSessionStub_());
                 sandbox.stub(webdriverio, "attach").resolves(mkSessionStub_());
                 sandbox.stub(webdriver.WebDriver, "newSession").resolves(mkSessionStub_());
-                browser = mkNewBrowser_({ saveHistory: true });
-
-                await browser.init();
-            });
-
-            mkTestsSet(() => browser, "addCommand");
-            mkTestsSet(() => browser, "overwriteCommand");
-        });
-
-        describe("ExistingBrowser", () => {
-            let browser;
-
-            beforeEach(async () => {
-                sandbox.stub(webdriverio, "attach").resolves(mkSessionStub_());
                 const ExistingBrowser = proxyquire("src/browser/existing-browser", {
                     "./client-bridge": {
                         build: sandbox.stub().resolves(),
                     },
                 }).ExistingBrowser;
-                browser = mkExistingBrowser_({ saveHistory: true }, undefined, ExistingBrowser);
+                browser = mkExistingBrowser_({ saveHistory: true }, void 0, ExistingBrowser);
 
-                await browser.init({ sessionOpts: {}, sessionCaps: {} });
+                await browser.init({ sessionId: "session-id", sessionCaps: {}, sessionOpts: { capabilities: {} } });
             });
 
             mkTestsSet(() => browser, "addCommand");

test/src/browser/new-browser.js

@@ -4,7 +4,7 @@ const crypto = require("crypto");
 const proxyquire = require("proxyquire");
 const signalHandler = require("src/signal-handler");
 const history = require("src/browser/history");
-const { WEBDRIVER_PROTOCOL, DEVTOOLS_PROTOCOL, SAVE_HISTORY_MODE } = require("src/constants/config");
+const { WEBDRIVER_PROTOCOL, DEVTOOLS_PROTOCOL } = require("src/constants/config");
 const { X_REQUEST_ID_DELIMITER } = require("src/constants/browser");
 const RuntimeConfig = require("src/config/runtime-config");
 const { mkNewBrowser_, mkSessionStub_, mkWdPool_ } = require("./utils");
@@ -384,39 +384,6 @@ describe("NewBrowser", () => {
             });
         });
 
-        describe("commands-history", () => {
-            it("should NOT init commands-history if it is off", async () => {
-                await mkBrowser_({ saveHistoryMode: SAVE_HISTORY_MODE.NONE }).init();
-
-                assert.notCalled(initCommandHistoryStub);
-            });
-
-            it("should save history of executed commands if it is enabled", async () => {
-                await mkBrowser_({ saveHistoryMode: SAVE_HISTORY_MODE.ALL }).init();
-
-                assert.calledOnceWith(initCommandHistoryStub, session);
-            });
-
-            it("should save history of executed commands if it is enabled on fails", async () => {
-                await mkBrowser_({ saveHistoryMode: "onlyFailed" }).init();
-
-                assert.calledOnceWith(initCommandHistoryStub, session);
-            });
-
-            it("should init commands-history before any commands have added", async () => {
-                await mkBrowser_({ saveHistoryMode: SAVE_HISTORY_MODE.ALL }).init();
-
-                assert.callOrder(initCommandHistoryStub, session.addCommand);
-            });
-
-            it('should log "init" to history if "saveHistoryMode" and "pageLoadTimeout" are set', async () => {
-                const browser = mkBrowser_({ saveHistoryMode: SAVE_HISTORY_MODE.ALL, pageLoadTimeout: 500100 });
-                await browser.init();
-
-                assert.calledOnceWith(runGroupStub, sinon.match.any, "testplane: init browser", sinon.match.func);
-            });
-        });
-
         describe("set page load timeout if it is specified in a config", () => {
             let browser;