fix: fix zero maxDelta non-renderable capture spec case during composite and unit tests

Author: shadowusr

src/browser/screen-shooter/composite-image/index.ts

@@ -262,11 +262,25 @@ export class CompositeImage {
                 hasRenderableDelta = true;
             }
 
-            if (!hasRenderableDelta || maxDelta === 0) {
+            if (!hasRenderableDelta) {
                 for (let i = 0; i < minLength; i++) {
                     const referenceSpec = referenceCaptureSpecs[i];
                     const chunkSpec = chunk.captureSpecs[i];
 
+                    const delta = subtractCoords(referenceSpec.full.top, chunkSpec.full.top);
+                    if (delta > maxDelta) {
+                        maxDelta = delta;
+                    }
+                }
+            } else if (maxDelta === 0) {
+                for (let i = 0; i < minLength; i++) {
+                    const referenceSpec = referenceCaptureSpecs[i];
+                    const chunkSpec = chunk.captureSpecs[i];
+
+                    if (!this._isRenderableCaptureSpec(chunkSpec)) {
+                        continue;
+                    }
+
                     const delta = subtractCoords(referenceSpec.full.top, chunkSpec.full.top);
                     if (delta > maxDelta) {
                         maxDelta = delta;

test/browser-env/screens/f1963d2/chrome/compute-safe-area-non-scrollable-modal-with-positioned-children.png

@@ -398,6 +398,7 @@ describe("ElementsScreenShooter", () => {
                 viewportSize: page.viewportSize,
                 viewportOffset: page.viewportOffset,
                 screenshotDelay: 500,
+                cropMargins: undefined,
             });
             assert.calledOnceWithExactly(
                 compositeImage.registerViewportImageAtOffset,
@@ -450,7 +451,7 @@ describe("ElementsScreenShooter", () => {
             const secondState = createCaptureState({
                 captureSpecs: page.captureSpecs,
                 safeArea: band(0, 150),
-                scrollOffset: 100,
+                scrollOffset: 50,
             });
 
             browserSideScreenshooter.call
@@ -471,7 +472,7 @@ describe("ElementsScreenShooter", () => {
             assert.calledTwice(compositeImage.registerViewportImageAtOffset);
             assert.deepEqual(browserSideScreenshooter.call.getCall(2).args, [
                 "scrollBy",
-                [[".element"], 100, undefined, []],
+                [[".element"], 50, undefined, []],
             ]);
             assert.deepEqual(browserSideScreenshooter.call.getCall(4).args, [
                 "scrollTo",