fix: exit successfully if last failed only is on and there are no failed tests (#1150)

* fix: exit successfully if last failed only is on and there are no failed tests

* fix: do not show keep-browser param in error message if no tests were found

Author: shadowusr

src/test-reader/index.ts

@@ -49,13 +49,13 @@ export class TestReader extends EventEmitter {
             parser.parse(files, { browserId, config: this.#config.forBrowser(browserId), grep }),
         );
 
-        validateTests(testsByBro, options);
+        validateTests(testsByBro, options, this.#config);
 
         return testsByBro;
     }
 }
 
-function validateTests(testsByBro: Record<string, Test[]>, options: TestReaderOpts): void {
+function validateTests(testsByBro: Record<string, Test[]>, options: TestReaderOpts, config: Config): void {
     const tests = _.flatten(Object.values(testsByBro));
 
     const singleTestModes = [
@@ -76,11 +76,11 @@ function validateTests(testsByBro: Record<string, Test[]>, options: TestReaderOp
         }
     }
 
-    if (!_.isEmpty(tests) && tests.some(test => !test.silentSkip)) {
+    if ((!_.isEmpty(tests) && tests.some(test => !test.silentSkip)) || (_.isEmpty(tests) && config.lastFailed.only)) {
         return;
     }
 
-    const stringifiedOpts = convertOptions(_.omit(options, "replMode"));
+    const stringifiedOpts = convertOptions(_.omit(options, "replMode", "keepBrowserMode"));
     if (_.isEmpty(stringifiedOpts)) {
         throw new Error(`There are no tests found. Try to specify [${Object.keys(options).join(", ")}] options`);
     } else {

src/test-reader/test-parser.ts

@@ -144,7 +144,11 @@ export class TestParser extends EventEmitter {
             treeBuilder.addTestFilter((test: Test) => grep.test(test.fullTitle()));
         }
 
-        if (config.lastFailed && config.lastFailed.only && this.#failedTests.size) {
+        if (config.lastFailed?.only) {
+            if (!this.#failedTests.size) {
+                return [];
+            }
+
             treeBuilder.addTestFilter(test => {
                 return this.#failedTests.has(
                     getFailedTestId({

test/src/test-reader/index.js

@@ -287,6 +287,21 @@ describe("test-reader", () => {
                     assert.equal(e.message, "There are no tests found by the specified options:\n" + "- grep: foo\n");
                 }
             });
+
+            it("should resolve successfully when last failed mode is enabled", async () => {
+                const config = makeConfigStub({
+                    browsers: ["bro"],
+                    lastFailed: {
+                        only: true,
+                        input: "last-failed.json",
+                        output: "last-failed-out.json",
+                    },
+                });
+
+                const testsByBrowser = await readTests_({ config });
+
+                assert.deepEqual(testsByBrowser, { bro: [] });
+            });
         });
 
         describe("repl mode", () => {