Skip to content

Commit 8974a04

Browse files
fix: show duplicate state name assert view errors
1 parent e194061 commit 8974a04

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

  • src/browser/commands/assert-view
  • test/src/browser/commands/assert-view

src/browser/commands/assert-view/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ const { getCaptureProcessors } = require("./capture-processors");
1111
const RuntimeConfig = require("../../../config/runtime-config");
1212
const AssertViewResults = require("./assert-view-results");
1313
const { BaseStateError } = require("./errors/base-state-error");
14-
const { AssertViewError } = require("./errors/assert-view-error");
1514

1615
const getIgnoreDiffPixelCountRatio = value => {
1716
const percent = _.isString(value) && value.endsWith("%") ? parseFloat(value.slice(0, -1)) : false;
@@ -55,7 +54,7 @@ module.exports.default = browser => {
5554
testplaneCtx.assertViewResults = testplaneCtx.assertViewResults || AssertViewResults.create();
5655

5756
if (testplaneCtx.assertViewResults.hasState(state)) {
58-
return Promise.reject(new AssertViewError(`duplicate name for "${state}" state`));
57+
return Promise.reject(new Error(`duplicate name for "${state}" state`));
5958
}
6059

6160
const handleCaptureProcessorError = e =>

test/src/browser/commands/assert-view/index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const { Image } = require("src/image");
88
const ScreenShooter = require("src/browser/screen-shooter");
99
const temp = require("src/temp");
1010
const validator = require("png-validator");
11-
const { AssertViewError } = require("src/browser/commands/assert-view/errors/assert-view-error");
1211
const { ImageDiffError } = require("src/browser/commands/assert-view/errors/image-diff-error");
1312
const { NoRefImageError } = require("src/browser/commands/assert-view/errors/no-ref-image-error");
1413
const RuntimeConfig = require("src/config/runtime-config");
@@ -149,7 +148,7 @@ describe("assertView command", () => {
149148
const elem = await browser.publicAPI.$(".selector");
150149
await elem.assertView("plain");
151150
} catch (e) {
152-
assert.instanceOf(e, AssertViewError);
151+
assert.instanceOf(e, Error);
153152
assert.equal(e.message, 'duplicate name for "plain" state');
154153
}
155154
});
@@ -210,7 +209,7 @@ describe("assertView command", () => {
210209
const elem = await browser.publicAPI.$(".selector");
211210
await elem.assertView("plain");
212211
} catch (e) {
213-
assert.instanceOf(e, AssertViewError);
212+
assert.instanceOf(e, Error);
214213
assert.equal(e.message, 'duplicate name for "plain" state');
215214
}
216215
});

0 commit comments

Comments
 (0)