feat(save-history-mode): fix save history mode #1

Author: rocketraccoon

src/browser/history/index.ts

@@ -51,6 +51,8 @@ interface RunWithHistoryHooksData<T> extends HooksData {
     fn: () => T;
 }
 
+export const DISABLE_OVERWRITE = "disable_overwrite";
+
 export const runWithoutHistory = async <T>(
     { callstack }: { callstack: HooksData["callstack"] },
     fn: () => T,
@@ -68,11 +70,7 @@ const skipNode = (callstack: Callstack, nodeData: NodeData): boolean => {
         return true;
     }
 
-    if (nodeData.name === "execute" && nodeData?.args[0]?.toString().includes("@disable-overwrite")) {
-        return true;
-    }
-
-    return false;
+    return nodeData?.args[1] === DISABLE_OVERWRITE;
 };
 
 const runWithHistoryHooks = <T>({ session, callstack, nodeData, fn, config }: RunWithHistoryHooksData<T>): T => {

src/browser/history/rrweb.ts

@@ -3,14 +3,14 @@ import { eventWithTime } from "@rrweb/types";
 import { MasterEvents } from "../../events";
 import { SnapshotsData, TestContext } from "../../types";
 import path from "path";
+import { DISABLE_OVERWRITE } from "./";
 
 const rrwebCode = fs.readFileSync(path.join(__dirname, "../client-scripts/rrweb-record.min.js"), "utf-8");
 
 export async function installRrwebAndCollectEvents(session: WebdriverIO.Browser): Promise<eventWithTime[]> {
     /* eslint-disable @typescript-eslint/ban-ts-comment */
     return session.execute(
-        (rrwebRecordFnCode, serverTime) => {
-            // @disable-overwrite
+        (_, rrwebRecordFnCode, serverTime) => {
             // @ts-expect-error
             if (!window.__testplaneTiming) {
                 // @ts-expect-error
@@ -91,6 +91,7 @@ export async function installRrwebAndCollectEvents(session: WebdriverIO.Browser)
 
             return result;
         },
+        DISABLE_OVERWRITE,
         rrwebCode,
         Date.now(),
     );