Merge pull request #1264 from gemini-testing/TRIVIAL.revert_assertViewDisplayed

Revert "fix: wait for element to be displayed before assertView (#1244)"

Author: KuznetsovRoman

src/browser/commands/assert-view/index.js

@@ -170,23 +170,23 @@ module.exports.default = browser => {
         testplaneCtx.assertViewResults.add({ stateName: state, refImg: refImg });
     };
 
-    const waitSelectorsForDisplayed = async (browser, selectors) => {
+    const waitSelectorsForExist = async (browser, selectors) => {
         await Promise.all(
             [].concat(selectors).map(selector =>
                 browser
                     .$(selector)
-                    .then(el => el.waitForDisplayed())
+                    .then(el => el.waitForExist())
                     .catch(() => {
                         throw new Error(
-                            `element ("${selector}") still not displayed after ${browser.options.waitforTimeout} ms`,
+                            `element ("${selector}") still not existing after ${browser.options.waitforTimeout} ms`,
                         );
                     }),
             ),
         );
     };
 
     const assertViewBySelector = async (browser, state, selectors, opts) => {
-        await waitSelectorsForDisplayed(browser, selectors);
+        await waitSelectorsForExist(browser, selectors);
 
         return assertView(state, selectors, opts);
     };
@@ -214,9 +214,9 @@ module.exports.default = browser => {
     session.addCommand(
         "assertView",
         async function (state, opts = {}) {
-            await this.waitForDisplayed({ timeoutMsg: "custom timeout msg" }).catch(() => {
+            await this.waitForExist({ timeoutMsg: "custom timeout msg" }).catch(() => {
                 throw new Error(
-                    `element ("${this.selector}") still not displayed after ${this.options.waitforTimeout} ms`,
+                    `element ("${this.selector}") still not existing after ${this.options.waitforTimeout} ms`,
                 );
             });
 

test/src/browser/commands/assert-view/index.js

@@ -119,24 +119,24 @@ describe("assertView command", () => {
         assert.equal(error.refImg.path, "/ref/invalid");
     });
 
-    it("should wait for all selectors to be displayed", async () => {
+    it("should wait for all selectors to exist", async () => {
         const browser = await initBrowser_();
         const element = await browser.publicAPI.$(".selector");
 
         await browser.publicAPI.assertView("plain", [".selector1", ".selector2"]);
 
         assert.calledWith(browser.publicAPI.$, ".selector1");
         assert.calledWith(browser.publicAPI.$, ".selector2");
-        assert.calledTwice(element.waitForDisplayed);
+        assert.calledTwice(element.waitForExist);
     });
 
-    it("should wait for element to be displayed", async () => {
+    it("should wait for element to exist", async () => {
         const browser = await initBrowser_();
         const element = await browser.publicAPI.$(".selector");
 
         await element.assertView("plain");
 
-        assert.calledOnce(element.waitForDisplayed);
+        assert.calledOnce(element.waitForExist);
     });
 
     it("should fail on duplicate name of the state on mixed scopes", async () => {

test/src/browser/utils.js

@@ -122,7 +122,6 @@ const mkSessionStub_ = () => {
         selector: ".selector",
         click: sinon.stub().named("click").resolves(),
         waitForExist: sinon.stub().named("waitForExist").resolves(),
-        waitForDisplayed: sinon.stub().named("waitForDisplayed").resolves(),
     };
 
     session.sessionId = "1234567890";