From 040f43bad32abb0b79e9546c9a6b9d6d4ef1f0a9 Mon Sep 17 00:00:00 2001 From: Roman Kuznetsov Date: Thu, 4 Sep 2025 14:39:39 +0300 Subject: [PATCH] fix: show duplicate state name assert view errors --- src/browser/commands/assert-view/index.js | 3 +-- test/src/browser/commands/assert-view/index.js | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/browser/commands/assert-view/index.js b/src/browser/commands/assert-view/index.js index ed5339054..c9b13f93e 100644 --- a/src/browser/commands/assert-view/index.js +++ b/src/browser/commands/assert-view/index.js @@ -11,7 +11,6 @@ const { getCaptureProcessors } = require("./capture-processors"); const RuntimeConfig = require("../../../config/runtime-config"); const AssertViewResults = require("./assert-view-results"); const { BaseStateError } = require("./errors/base-state-error"); -const { AssertViewError } = require("./errors/assert-view-error"); const getIgnoreDiffPixelCountRatio = value => { const percent = _.isString(value) && value.endsWith("%") ? parseFloat(value.slice(0, -1)) : false; @@ -55,7 +54,7 @@ module.exports.default = browser => { testplaneCtx.assertViewResults = testplaneCtx.assertViewResults || AssertViewResults.create(); if (testplaneCtx.assertViewResults.hasState(state)) { - return Promise.reject(new AssertViewError(`duplicate name for "${state}" state`)); + return Promise.reject(new Error(`duplicate name for "${state}" state`)); } const handleCaptureProcessorError = e => diff --git a/test/src/browser/commands/assert-view/index.js b/test/src/browser/commands/assert-view/index.js index 017c0b985..c310a983e 100644 --- a/test/src/browser/commands/assert-view/index.js +++ b/test/src/browser/commands/assert-view/index.js @@ -8,7 +8,6 @@ const { Image } = require("src/image"); const ScreenShooter = require("src/browser/screen-shooter"); const temp = require("src/temp"); const validator = require("png-validator"); -const { AssertViewError } = require("src/browser/commands/assert-view/errors/assert-view-error"); const { ImageDiffError } = require("src/browser/commands/assert-view/errors/image-diff-error"); const { NoRefImageError } = require("src/browser/commands/assert-view/errors/no-ref-image-error"); const RuntimeConfig = require("src/config/runtime-config"); @@ -149,7 +148,7 @@ describe("assertView command", () => { const elem = await browser.publicAPI.$(".selector"); await elem.assertView("plain"); } catch (e) { - assert.instanceOf(e, AssertViewError); + assert.instanceOf(e, Error); assert.equal(e.message, 'duplicate name for "plain" state'); } }); @@ -210,7 +209,7 @@ describe("assertView command", () => { const elem = await browser.publicAPI.$(".selector"); await elem.assertView("plain"); } catch (e) { - assert.instanceOf(e, AssertViewError); + assert.instanceOf(e, Error); assert.equal(e.message, 'duplicate name for "plain" state'); } });