wallet-connect: add SIWE validation and tests

Introduce SignMessageValidation and SIWE validation flow for WalletConnect sign messages. Validator now accepts a SignMessageValidation struct, decodes hex/text SIWE payloads, validates chain ID and session domain, and returns explicit errors for mismatches. Export SignMessageValidation from the crate and add a siwe_mock test helper used across tests. The commit also applies numerous minor formatting and line-wrapping cleanups across multiple crates (non-functional whitespace/formatting changes) and updates call sites to the new validator API.

Author: gemcoder21

apps/api/src/devices/guard.rs

@@ -70,10 +70,7 @@ async fn authenticate<T>(req: &Request<'_>) -> Result<AuthResult, Outcome<T, Str
         Error((status, msg))
     })?;
 
-    let wallet_id = components
-        .wallet_id
-        .clone()
-        .or_else(|| req.headers().get_one(HEADER_WALLET_ID).map(|s| s.to_string()));
+    let wallet_id = components.wallet_id.clone().or_else(|| req.headers().get_one(HEADER_WALLET_ID).map(|s| s.to_string()));
 
     Ok(AuthResult {
         device_id: components.device_id,

apps/api/src/devices/mod.rs

@@ -9,18 +9,20 @@ use crate::assets::AssetsClient;
 use crate::metrics::fiat::FiatMetrics;
 use crate::params::{AssetIdParam, ChainParam, ChartPeriodParam, CurrencyParam, DeviceIdParam, DeviceParam, FiatQuoteTypeParam, TransactionIdParam, UserAgent};
 use crate::responders::{ApiError, ApiResponse};
-pub use clients::{FiatQuotesClient, NotificationsClient, PortfolioClient, RewardsClient, RewardsRedemptionClient, ScanClient, ScanProviderFactory, TransactionsClient, WalletsClient};
-pub(crate) use clients::WalletSubscriptionInput;
 use auth_config::AuthConfig;
 pub use client::DevicesClient;
+pub(crate) use clients::WalletSubscriptionInput;
+pub use clients::{
+    FiatQuotesClient, NotificationsClient, PortfolioClient, RewardsClient, RewardsRedemptionClient, ScanClient, ScanProviderFactory, TransactionsClient, WalletsClient,
+};
 use gem_auth::AuthClient;
 use guard::{AuthenticatedDevice, AuthenticatedDeviceWallet, VerifiedDeviceId};
+use name_resolver::client::Client as NameClient;
 use nft::NFTClient;
 use primitives::DeviceToken;
 use primitives::device::Device;
-use primitives::rewards::{RedemptionRequest, RedemptionResult, RewardRedemptionOption};
-use name_resolver::client::Client as NameClient;
 use primitives::name::NameRecord;
+use primitives::rewards::{RedemptionRequest, RedemptionResult, RewardRedemptionOption};
 use primitives::{
     AssetId, AuthNonce, FiatAssets, FiatQuoteRequest, FiatQuoteType, FiatQuoteUrl, FiatQuotes, InAppNotification, MigrateDeviceIdRequest, NFTData, PortfolioAssets,
     PortfolioAssetsRequest, PriceAlerts, ReportNft, RewardEvent, Rewards, ScanTransaction, ScanTransactionPayload, Transaction, TransactionsResponse, WalletSubscriptionChains,
@@ -105,7 +107,11 @@ pub async fn get_device_transactions_v2(
 }
 
 #[get("/devices/transactions/<id>")]
-pub async fn get_device_transaction_by_id_v2(_device: AuthenticatedDevice, id: TransactionIdParam, client: &State<Mutex<TransactionsClient>>) -> Result<ApiResponse<Transaction>, ApiError> {
+pub async fn get_device_transaction_by_id_v2(
+    _device: AuthenticatedDevice,
+    id: TransactionIdParam,
+    client: &State<Mutex<TransactionsClient>>,
+) -> Result<ApiResponse<Transaction>, ApiError> {
     Ok(client.lock().await.get_transaction_by_id(&id.0)?.into())
 }
 
@@ -125,7 +131,11 @@ pub async fn get_device_rewards_events_v2(device: AuthenticatedDeviceWallet, cli
 }
 
 #[get("/devices/rewards/redemptions/<code>")]
-pub async fn get_device_rewards_redemption_v2(_device: AuthenticatedDevice, code: &str, client: &State<Mutex<RewardsClient>>) -> Result<ApiResponse<RewardRedemptionOption>, ApiError> {
+pub async fn get_device_rewards_redemption_v2(
+    _device: AuthenticatedDevice,
+    code: &str,
+    client: &State<Mutex<RewardsClient>>,
+) -> Result<ApiResponse<RewardRedemptionOption>, ApiError> {
     Ok(client.lock().await.get_rewards_redemption_option(code)?.into())
 }
 
@@ -213,7 +223,12 @@ pub async fn report_device_nft_v2(device: AuthenticatedDevice, request: Json<Rep
 }
 
 #[get("/devices/name/resolve/<name>?<chain>")]
-pub async fn get_device_name_resolve_v2(_device: AuthenticatedDevice, name: &str, chain: ChainParam, client: &State<Mutex<NameClient>>) -> Result<ApiResponse<Option<NameRecord>>, ApiError> {
+pub async fn get_device_name_resolve_v2(
+    _device: AuthenticatedDevice,
+    name: &str,
+    chain: ChainParam,
+    client: &State<Mutex<NameClient>>,
+) -> Result<ApiResponse<Option<NameRecord>>, ApiError> {
     let result = client.lock().await.resolve(name, chain.0).await;
     match result {
         Ok(record) => Ok(Some(record).into()),
@@ -306,12 +321,21 @@ pub async fn delete_device_price_alerts_v2(
 }
 
 #[get("/devices/fiat/orders/<provider>/<order_id>")]
-pub async fn get_device_fiat_order_v2(_device: AuthenticatedDevice, provider: &str, order_id: &str, client: &State<Mutex<FiatQuotesClient>>) -> Result<ApiResponse<primitives::FiatTransaction>, ApiError> {
+pub async fn get_device_fiat_order_v2(
+    _device: AuthenticatedDevice,
+    provider: &str,
+    order_id: &str,
+    client: &State<Mutex<FiatQuotesClient>>,
+) -> Result<ApiResponse<primitives::FiatTransaction>, ApiError> {
     Ok(client.lock().await.get_order_status(provider, order_id).await?.into())
 }
 
 #[get("/devices/fiat/assets/<quote_type>")]
-pub async fn get_device_fiat_assets_v2(_device: AuthenticatedDevice, quote_type: FiatQuoteTypeParam, client: &State<Mutex<FiatQuotesClient>>) -> Result<ApiResponse<FiatAssets>, ApiError> {
+pub async fn get_device_fiat_assets_v2(
+    _device: AuthenticatedDevice,
+    quote_type: FiatQuoteTypeParam,
+    client: &State<Mutex<FiatQuotesClient>>,
+) -> Result<ApiResponse<FiatAssets>, ApiError> {
     let assets = match quote_type.0 {
         FiatQuoteType::Buy => client.lock().await.get_on_ramp_assets().await?,
         FiatQuoteType::Sell => client.lock().await.get_off_ramp_assets().await?,
@@ -371,9 +395,5 @@ pub async fn get_device_portfolio_assets_v2(
     request: Json<PortfolioAssetsRequest>,
     portfolio_client: &State<Mutex<PortfolioClient>>,
 ) -> Result<ApiResponse<PortfolioAssets>, ApiError> {
-    Ok(portfolio_client
-        .lock()
-        .await
-        .get_portfolio_charts(request.0.assets, period.0)?
-        .into())
+    Ok(portfolio_client.lock().await.get_portfolio_charts(request.0.assets, period.0)?.into())
 }

apps/api/src/main.rs

@@ -24,20 +24,20 @@ use std::{str::FromStr, sync::Arc};
 use strum::IntoEnumIterator;
 
 use ::fiat::FiatClient;
+use ::fiat::FiatProviderFactory;
 use ::nft::{NFTClient, NFTProviderConfig};
 use api_connector::PusherClient;
 use assets::{AssetsClient, SearchClient};
 use cacher::CacherClient;
 use config::ConfigClient;
 use devices::DevicesClient;
-use ::fiat::FiatProviderFactory;
+use devices::{FiatQuotesClient, NotificationsClient, PortfolioClient, RewardsClient, RewardsRedemptionClient, ScanClient, ScanProviderFactory, TransactionsClient, WalletsClient};
 use gem_auth::AuthClient;
 use gem_rewards::{AbuseIPDBClient, IpApiClient, IpCheckProvider, IpSecurityClient};
 use metrics::fiat::FiatMetrics;
 use model::APIService;
 use name_resolver::NameProviderFactory;
 use name_resolver::client::{Client as NameClient, NameConfig};
-use devices::{FiatQuotesClient, NotificationsClient, PortfolioClient, RewardsClient, RewardsRedemptionClient, ScanClient, ScanProviderFactory, TransactionsClient, WalletsClient};
 use pricer::{ChartClient, MarketsClient, PriceAlertClient, PriceClient};
 use rocket::tokio::sync::Mutex;
 use rocket::{Build, Rocket, catchers, routes};

apps/daemon/src/setup/mod.rs

@@ -10,7 +10,7 @@ use storage::Database;
 use storage::models::{ChartRow, ConfigRow, FiatAssetRow, FiatProviderCountryRow, FiatRateRow, PriceAssetRow, PriceRow, UpdateDeviceRow};
 use storage::sql_types::{Platform, PlatformStore};
 use storage::{
-    AssetsRepository, ChartsRepository, ChainsRepository, ConfigRepository, DevicesRepository, MigrationsRepository, NewNotificationRow, NewWalletRow, NotificationsRepository,
+    AssetsRepository, ChainsRepository, ChartsRepository, ConfigRepository, DevicesRepository, MigrationsRepository, NewNotificationRow, NewWalletRow, NotificationsRepository,
     PriceAlertsRepository, PricesDexRepository, PricesRepository, ReleasesRepository, RewardsRepository, TagRepository, WalletSource, WalletType, WalletsRepository,
 };
 use streamer::{ExchangeKind, ExchangeName, QueueName, StreamProducer, StreamProducerConfig};

apps/dynode/src/metrics/mod.rs

@@ -266,5 +266,4 @@ mod tests {
         assert_eq!(m.truncate_method("/api/v1/blocks/by_height/12345"), "/api/v1/blocks/by_height/:number");
         assert_eq!(m.truncate_method("/v1/verylongsegmentthatisgreaterthan20characters"), "/v1/:value");
     }
-
 }

crates/gem_cosmos/src/provider/staking_mapper.rs

@@ -61,7 +61,14 @@ pub fn map_staking_validators(validators: Vec<Validator>, chain: CosmosChain, ap
             let is_active = !validator.jailed && validator.status == BOND_STATUS_BONDED;
             let validator_apr = if is_active { apy.map(|apr| apr - (apr * commission_rate)).unwrap_or(0.0) } else { 0.0 };
 
-            DelegationValidator::stake(chain.as_chain(), validator.operator_address, validator.description.moniker, is_active, commission_rate * 100.0, validator_apr)
+            DelegationValidator::stake(
+                chain.as_chain(),
+                validator.operator_address,
+                validator.description.moniker,
+                is_active,
+                commission_rate * 100.0,
+                validator_apr,
+            )
         })
         .collect()
 }

crates/gem_cosmos/src/provider/transactions_mapper.rs

@@ -46,11 +46,7 @@ pub fn map_transactions(chain: CosmosChain, transactions: Vec<TransactionRespons
 }
 
 fn asset_id_from_denom(chain: primitives::Chain, denom: &str, default_denom: &str) -> AssetId {
-    if denom == default_denom {
-        chain.as_asset_id()
-    } else {
-        AssetId::token(chain, denom)
-    }
+    if denom == default_denom { chain.as_asset_id() } else { AssetId::token(chain, denom) }
 }
 
 pub fn map_transaction(cosmos_chain: CosmosChain, body: TransactionBody, auth_info: Option<AuthInfo>, transaction: TransactionResponse) -> Option<Transaction> {
@@ -60,10 +56,7 @@ pub fn map_transaction(cosmos_chain: CosmosChain, body: TransactionBody, auth_in
     let native_asset_id = chain.as_asset_id();
 
     let fee_coin = auth_info.and_then(|info| info.fee.amount.into_iter().next());
-    let fee = fee_coin
-        .as_ref()
-        .map(|f| f.amount.clone())
-        .unwrap_or_else(|| get_base_fee(cosmos_chain).to_string());
+    let fee = fee_coin.as_ref().map(|f| f.amount.clone()).unwrap_or_else(|| get_base_fee(cosmos_chain).to_string());
     let fee_asset_id = fee_coin
         .as_ref()
         .map(|coin| asset_id_from_denom(chain, &coin.denom, &default_denom))

crates/gem_evm/src/provider/preload.rs

@@ -13,9 +13,9 @@ use chain_traits::ChainTransactionLoad;
 use gem_client::Client;
 #[cfg(feature = "rpc")]
 use num_bigint::BigInt;
-use primitives::GasPriceType;
 #[cfg(feature = "rpc")]
 use primitives::ContractCallData;
+use primitives::GasPriceType;
 #[cfg(feature = "rpc")]
 use primitives::{FeeRate, TransactionFee, TransactionInputType, TransactionLoadData, TransactionLoadInput, TransactionLoadMetadata, TransactionPreloadInput};
 #[cfg(feature = "rpc")]

crates/gem_evm/src/provider/preload_mapper.rs

@@ -8,7 +8,8 @@ use num_bigint::BigInt;
 use num_traits::Num;
 use primitives::swap::SwapQuoteDataType;
 use primitives::{
-    AssetSubtype, Chain, EVMChain, FeeRate, NFTType, StakeType, TransactionInputType, TransactionLoadInput, TransactionLoadMetadata, decode_hex, fee::FeePriority, fee::GasPriceType,
+    AssetSubtype, Chain, EVMChain, FeeRate, NFTType, StakeType, TransactionInputType, TransactionLoadInput, TransactionLoadMetadata, decode_hex, fee::FeePriority,
+    fee::GasPriceType,
 };
 
 use crate::contracts::{IERC20, IERC721, IERC1155};
@@ -100,11 +101,7 @@ pub fn get_transaction_params(chain: EVMChain, input: &TransactionLoadInput) ->
                         BigInt::from_str_radix(&swap_data.data.value, 10)?,
                     )),
                     AssetSubtype::TOKEN => match swap_data.data.data_type {
-                        SwapQuoteDataType::Contract => Ok(TransactionParams::new(
-                            swap_data.data.to.clone(),
-                            hex::decode(swap_data.data.data.clone())?,
-                            BigInt::ZERO,
-                        )),
+                        SwapQuoteDataType::Contract => Ok(TransactionParams::new(swap_data.data.to.clone(), hex::decode(swap_data.data.data.clone())?, BigInt::ZERO)),
                         SwapQuoteDataType::Transfer => {
                             let to = from_asset.token_id.clone().ok_or("Missing token ID")?.clone();
                             let data = encode_erc20_transfer(&swap_data.data.to.clone(), &BigInt::from_str_radix(&input.value, 10)?)?;
@@ -153,7 +150,11 @@ pub fn get_transaction_params(chain: EVMChain, input: &TransactionLoadInput) ->
             if let Some(approval) = &earn_data.approval {
                 Ok(TransactionParams::new_approval(approval.token.clone(), encode_erc20_approve(&approval.spender)?))
             } else {
-                Ok(TransactionParams::new(earn_data.contract_address.clone(), decode_hex(&earn_data.call_data)?, BigInt::from(0)))
+                Ok(TransactionParams::new(
+                    earn_data.contract_address.clone(),
+                    decode_hex(&earn_data.call_data)?,
+                    BigInt::from(0),
+                ))
             }
         }
         _ => Err("Unsupported transfer type".into()),
@@ -195,7 +196,9 @@ pub fn get_extra_fee_gas_limit(input: &TransactionLoadInput) -> Result<BigInt, B
             }
         }
         TransactionInputType::Earn(_, _, earn_data) => {
-            if earn_data.approval.is_some() && let Some(gas_limit) = &earn_data.gas_limit {
+            if earn_data.approval.is_some()
+                && let Some(gas_limit) = &earn_data.gas_limit
+            {
                 return Ok(BigInt::from_str_radix(gas_limit, 10)?);
             }
             Ok(BigInt::from(0))
@@ -431,7 +434,14 @@ mod tests {
 
     #[test]
     fn test_encode_stake_hub_delegate() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
-        let validator = DelegationValidator::stake(Chain::SmartChain, "0x773760b0708a5Cc369c346993a0c225D8e4043B1".to_string(), "Test Validator".to_string(), true, 5.0, 10.0);
+        let validator = DelegationValidator::stake(
+            Chain::SmartChain,
+            "0x773760b0708a5Cc369c346993a0c225D8e4043B1".to_string(),
+            "Test Validator".to_string(),
+            true,
+            5.0,
+            10.0,
+        );
 
         let stake_type = StakeType::Stake(validator);
         let amount = BigInt::from(1_000_000_000_000_000_000u64); // 1 BNB
@@ -460,7 +470,14 @@ mod tests {
                 delegation_id: "test".to_string(),
                 validator_id: "0x343dA7Ff0446247ca47AA41e2A25c5Bbb230ED0A".to_string(),
             },
-            validator: DelegationValidator::stake(Chain::SmartChain, "0x343dA7Ff0446247ca47AA41e2A25c5Bbb230ED0A".to_string(), "Test Validator".to_string(), true, 5.0, 10.0),
+            validator: DelegationValidator::stake(
+                Chain::SmartChain,
+                "0x343dA7Ff0446247ca47AA41e2A25c5Bbb230ED0A".to_string(),
+                "Test Validator".to_string(),
+                true,
+                5.0,
+                10.0,
+            ),
             price: None,
         };
 
@@ -490,11 +507,25 @@ mod tests {
                 delegation_id: "test".to_string(),
                 validator_id: "0x773760b0708a5Cc369c346993a0c225D8e4043B1".to_string(),
             },
-            validator: DelegationValidator::stake(Chain::SmartChain, "0x773760b0708a5Cc369c346993a0c225D8e4043B1".to_string(), "Source Validator".to_string(), true, 5.0, 10.0),
+            validator: DelegationValidator::stake(
+                Chain::SmartChain,
+                "0x773760b0708a5Cc369c346993a0c225D8e4043B1".to_string(),
+                "Source Validator".to_string(),
+                true,
+                5.0,
+                10.0,
+            ),
             price: None,
         };
 
-        let to_validator = DelegationValidator::stake(Chain::SmartChain, "0x343dA7Ff0446247ca47AA41e2A25c5Bbb230ED0A".to_string(), "Target Validator".to_string(), true, 3.0, 12.0);
+        let to_validator = DelegationValidator::stake(
+            Chain::SmartChain,
+            "0x343dA7Ff0446247ca47AA41e2A25c5Bbb230ED0A".to_string(),
+            "Target Validator".to_string(),
+            true,
+            3.0,
+            12.0,
+        );
 
         let redelegate_data = RedelegateData { delegation, to_validator };
 
@@ -524,7 +555,14 @@ mod tests {
                 delegation_id: "test".to_string(),
                 validator_id: "0x343dA7Ff0446247ca47AA41e2A25c5Bbb230ED0A".to_string(),
             },
-            validator: DelegationValidator::stake(Chain::SmartChain, "0x343dA7Ff0446247ca47AA41e2A25c5Bbb230ED0A".to_string(), "Test Validator".to_string(), true, 5.0, 10.0),
+            validator: DelegationValidator::stake(
+                Chain::SmartChain,
+                "0x343dA7Ff0446247ca47AA41e2A25c5Bbb230ED0A".to_string(),
+                "Test Validator".to_string(),
+                true,
+                5.0,
+                10.0,
+            ),
             price: None,
         };
 

crates/gem_evm/src/provider/staking_ethereum.rs

@@ -25,7 +25,14 @@ impl<C: Client + Clone> EthereumClient<C> {
     }
 
     pub async fn get_ethereum_validators(&self, apy: f64) -> Result<Vec<DelegationValidator>, Box<dyn Error + Sync + Send>> {
-        Ok(vec![DelegationValidator::stake(Chain::Ethereum, EVERSTAKE_POOL_ADDRESS.to_string(), "Everstake".to_string(), true, 0.1, apy)])
+        Ok(vec![DelegationValidator::stake(
+            Chain::Ethereum,
+            EVERSTAKE_POOL_ADDRESS.to_string(),
+            "Everstake".to_string(),
+            true,
+            0.1,
+            apy,
+        )])
     }
 
     pub async fn get_ethereum_delegations(&self, address: &str) -> Result<Vec<DelegationBase>, Box<dyn Error + Sync + Send>> {