Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions crates/gem_aptos/src/provider/transactions_mapper.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,11 @@ fn map_swap_transaction(transaction: Transaction, events: Vec<Event>, chain: Cha
];

let swap = SwapMapper::map_swap(&balance_diffs, &BigUint::from(0u8), &chain.as_asset_id(), Some(SwapProvider::Panora.id().to_owned()))?;
let asset_id = swap.from_asset.clone();
let metadata = serde_json::to_value(&swap).ok();
let to = meta.sender.clone();

return Some(build_transaction(meta, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata));
return Some(build_transaction(meta, asset_id, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata));
Comment on lines +101 to +105

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

By serializing swap to metadata first, we can avoid cloning swap.from_asset and instead move it directly into build_transaction. This avoids an unnecessary heap allocation for the AssetId's token ID string.

Suggested change
let asset_id = swap.from_asset.clone();
let metadata = serde_json::to_value(&swap).ok();
let to = meta.sender.clone();
return Some(build_transaction(meta, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata));
return Some(build_transaction(meta, asset_id, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata));
let metadata = serde_json::to_value(&swap).ok();
let asset_id = swap.from_asset;
let to = meta.sender.clone();
return Some(build_transaction(meta, asset_id, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata));

}

let withdraw_event = events.iter().find(|e| e.event_type == FUNGIBLE_ASSET_WITHDRAW_EVENT)?;
Expand Down Expand Up @@ -149,30 +150,32 @@ fn map_swap_transaction(transaction: Transaction, events: Vec<Event>, chain: Cha
});

let swap = SwapMapper::map_swap(&balance_diffs, &BigUint::from(0u8), &chain.as_asset_id(), provider)?;
let asset_id = swap.from_asset.clone();
let metadata = serde_json::to_value(&swap).ok();
let to = meta.sender.clone();

Some(build_transaction(meta, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata))
Some(build_transaction(meta, asset_id, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata))
Comment on lines +153 to +157

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similarly, we can serialize swap to metadata first to avoid cloning swap.from_asset and instead move it directly into build_transaction.

Suggested change
let asset_id = swap.from_asset.clone();
let metadata = serde_json::to_value(&swap).ok();
let to = meta.sender.clone();
Some(build_transaction(meta, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata))
Some(build_transaction(meta, asset_id, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata))
let metadata = serde_json::to_value(&swap).ok();
let asset_id = swap.from_asset;
let to = meta.sender.clone();
Some(build_transaction(meta, asset_id, chain.as_asset_id(), to, swap.from_value, TransactionType::Swap, metadata))

}

fn build_transaction(
meta: TransactionMeta,
asset_id: AssetId,
fee_asset_id: AssetId,
to: String,
value: String,
transaction_type: TransactionType,
metadata: Option<serde_json::Value>,
) -> PrimitivesTransaction {
PrimitivesTransaction::new(
meta.hash,
asset_id.clone(),
asset_id,
meta.sender,
to,
None,
transaction_type,
meta.state,
meta.fee,
asset_id,
fee_asset_id,
value,
None,
metadata,
Expand All @@ -196,6 +199,7 @@ pub fn map_transaction(transaction: Transaction) -> Option<PrimitivesTransaction
let data: DelegationPoolAddStakeData = serde_json::from_value(event.data.clone()?).ok()?;
return Some(build_transaction(
meta,
asset_id.clone(),
asset_id,
data.pool_address,
data.amount_added,
Expand All @@ -207,6 +211,7 @@ pub fn map_transaction(transaction: Transaction) -> Option<PrimitivesTransaction
let data: DelegationPoolUnlockStakeData = serde_json::from_value(event.data.clone()?).ok()?;
return Some(build_transaction(
meta,
asset_id.clone(),
asset_id,
data.pool_address,
data.amount_unlocked,
Expand All @@ -231,7 +236,7 @@ pub fn map_transaction(transaction: Transaction) -> Option<PrimitivesTransaction

let value = deposit_event.get_amount()?;

return Some(build_transaction(meta, asset_id, to, value, TransactionType::Transfer, None));
return Some(build_transaction(meta, asset_id.clone(), asset_id, to, value, TransactionType::Transfer, None));
}
None
}
Expand Down Expand Up @@ -315,6 +320,8 @@ mod tests {
assert_eq!(tx.to, "0x4eb20e735591a85bb58921ef2e6b55c385bba10e817ffe1e02e50deb6c594aef");
assert_eq!(tx.state, TransactionState::Confirmed);
assert_eq!(tx.transaction_type, TransactionType::Swap);
assert_eq!(tx.asset_id, AssetId::from_token(Chain::Aptos, APTOS_USDT_TOKEN_ID));
assert_eq!(tx.fee_asset_id, Chain::Aptos.as_asset_id());
assert_eq!(tx.fee, "142600");
assert!(tx.metadata.is_some());

Expand Down
4 changes: 3 additions & 1 deletion crates/gem_sui/src/provider/transactions_mapper.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,9 @@ fn map_transaction_type(
_ => return None,
};
let owner = owner.clone()?;
let asset_id = swap.from_asset.clone();
return Some((
chain.as_asset_id(),
asset_id,
owner.clone(),
owner,
TransactionType::Swap,
Expand Down Expand Up @@ -366,6 +367,7 @@ mod tests {
.unwrap();

assert_eq!(swap.transaction_type, TransactionType::Swap);
assert_eq!(swap.asset_id, AssetId::from_token(Chain::Sui, TOKEN_A));
assert_eq!(swap.value, "200");
let metadata: TransactionSwapMetadata = serde_json::from_value(swap.metadata.unwrap()).unwrap();
assert_eq!(metadata.from_asset, AssetId::from_token(Chain::Sui, TOKEN_A));
Expand Down
Loading