Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Always use Dockerfile amd64 arch#251

Merged
0xh3rman merged 8 commits into
mainfrom
amd64-image
Dec 18, 2025
Merged

Always use Dockerfile amd64 arch#251
0xh3rman merged 8 commits into
mainfrom
amd64-image

Conversation

@0xh3rman

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing and enforcing the amd64 architecture for Docker-based builds of the Android application. It modifies the Dockerfile to ensure amd64 dependencies are installed, updates build scripts to explicitly target linux/amd64 for Docker operations, and refactors the verification pipeline to handle platform specifications more robustly. These changes aim to improve build reproducibility and consistency across different environments, while also laying groundwork for potential arm64 support.

Highlights

  • Standardized amd64 Docker Builds: The Dockerfile now explicitly adds amd64 architecture and installs amd64 specific runtime dependencies, ensuring consistency for the base image.
  • Explicit Platform Specification: Build commands in justfile and verify_apk.py have been updated to explicitly specify linux/amd64 as the target platform for Docker builds, preventing potential cross-architecture build issues.
  • Enhanced Build Script Flexibility: The reproducible/verify_apk.py script has been refactored to accept and pass platform arguments to Docker commands, and a new VERIFY_DOCKER_PLATFORM environment variable allows overriding the default linux/amd64 verification platform.
  • Documentation Updates: The reproducible/README.md has been updated to reflect the support for linux/amd64 and linux/arm64 base image publishing and clarifies the default verification platform.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/publish-base-image.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the Docker build architecture to amd64 to ensure build consistency across different development environments. The changes correctly modify the Dockerfile to use amd64 libraries, update the justfile to specify the linux/amd64 platform, and refactor the reproducible/verify_apk.py script to enforce this platform while allowing for overrides. The documentation is also updated accordingly. The changes are logical and well-implemented. I have one minor suggestion to improve consistency within the Python script.

Comment thread reproducible/verify_apk.py
@0xh3rman 0xh3rman merged commit bd15be2 into main Dec 18, 2025
3 of 4 checks passed
@0xh3rman 0xh3rman deleted the amd64-image branch December 18, 2025 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants