fix: Suppress warnings to allow github workflow to pass

Author: azu-compent

.gitattributes

@@ -0,0 +1 @@
+* text eol=crlf

.github/workflows/main.yml

@@ -34,6 +34,6 @@ jobs:
     - name: Restore packages
       run: dotnet restore Arch.Extended.sln
     - name: Build
-      run: dotnet build Arch.Extended.sln -c ${{ matrix.config }} --no-restore
+      run: dotnet build Arch.Extended.sln -c ${{ matrix.config }} --no-restore -warnaserror
     - name: Test
       run: dotnet test Arch.Extended.sln -c ${{ matrix.config }} -l "console;verbosity=detailed"

Arch.AOT.SourceGenerator/SourceGenerator.cs

@@ -31,6 +31,8 @@ namespace Arch.AOT.SourceGenerator
 	                                             public sealed class ComponentAttribute : Attribute { }
 	                                         }
 	                                         """;
+
+	/// <inheritdoc cref="IIncrementalGenerator.Initialize"/>
 	public void Initialize(IncrementalGeneratorInitializationContext context)
 	{
 		// Register the attribute.

Arch.EventBus/EventBus.cs

@@ -64,6 +64,9 @@ public struct ReceivingMethod
     public int Order;
 }
 
+/// <summary>
+/// EventBusExtensions
+/// </summary>
 public static class EventBusExtensions
 {
 
@@ -86,7 +89,7 @@ public static string RefKindToString(RefKind refKind)
             case RefKind.Out:
                 return "out";
         }
-        return null;
+        return null!;
     }
 
     /// <summary>
@@ -108,7 +111,7 @@ public static StringBuilder AppendEventMethods(this StringBuilder sb, IList<Meth
     ///     Appends all methods redirecting events.
     /// </summary>
     /// <param name="sb">The <see cref="StringBuilder"/>.</param>
-    /// <param name="callMethods">The <see cref="IList{T}"/> containing the <see cref="Method"/>s redirecting the event and calling the methods. </param>
+    /// <param name="callMethod">The <see cref="IList{T}"/> containing the <see cref="Method"/>s redirecting the event and calling the methods. </param>
     /// <returns></returns>
     public static StringBuilder AppendEventMethod(this StringBuilder sb, Method callMethod)
     {

Arch.EventBus/Hooks.cs

@@ -3,14 +3,30 @@
 
 namespace Arch.Bus;
 
+/// <summary>
+/// Hooks.
+/// </summary>
 public struct Hooks
 {
+    /// <summary>
+    /// Instances.
+    /// </summary>
     public List<ClassHooks> Instances;
 }
 
+/// <summary>
+/// Class hooks.
+/// </summary>
 public struct ClassHooks
 {
+    /// <summary>
+    /// Partial class.
+    /// </summary>
     public ITypeSymbol PartialClass;
+
+    /// <summary>
+    /// Event hooks.
+    /// </summary>
     public IList<EventHook> EventHooks;
 }
 
@@ -32,7 +48,10 @@ public struct EventHook
     public IMethodSymbol MethodSymbol;
 }
 
-public static class Hookersxtensions
+/// <summary>
+/// Hook extensions.
+/// </summary>
+public static class HookExtensions
 {
 
     /// <summary>

Arch.EventBus/IMethodSymbolExtensions.cs Arch.EventBus/MethodSymbolExtensions.csArch.EventBus/IMethodSymbolExtensions.cs renamed to Arch.EventBus/MethodSymbolExtensions.cs

@@ -2,7 +2,10 @@
 
 namespace Arch.Bus;
 
-public static class IMethodSymbolExtensions
+/// <summary>
+/// Method symbol extensions.
+/// </summary>
+public static class MethodSymbolExtensions
 {
 
     /// <summary>
@@ -16,12 +19,12 @@ public static AttributeData GetAttributeData(this IMethodSymbol ms, string name)
         foreach (var attribute in ms.GetAttributes())
         {
             var classSymbol = attribute.AttributeClass;
-            if(!classSymbol.Name.Contains(name)) continue;
+            if(!classSymbol!.Name.Contains(name)) continue;
 
             return attribute;
         }
 
-        return default;
+        return default!;
     }
 
     /// <summary>
@@ -30,17 +33,17 @@ public static AttributeData GetAttributeData(this IMethodSymbol ms, string name)
     /// </summary>
     /// <param name="data">The <see cref="AttributeData"/>.</param>
     /// <param name="array">The <see cref="List{T}"/> where the found <see cref="ITypeSymbol"/>s are added to.</param>
-    public static void GetAttributeTypes(this AttributeData data, List<ITypeSymbol> array)
+    public static void GetAttributeTypes(this AttributeData? data, List<ITypeSymbol> array)
     {
-        if (data is not null && data.AttributeClass.IsGenericType)
+        if (data is not null && data.AttributeClass!.IsGenericType)
         {
             array.AddRange(data.AttributeClass.TypeArguments);
         }
-        else if (data is not null && !data.AttributeClass.IsGenericType)
+        else if (data is not null && !data.AttributeClass!.IsGenericType)
         {
             var constructorArguments = data.ConstructorArguments[0].Values;
             var constructorArgumentsTypes = constructorArguments.Select(constant => constant.Value as ITypeSymbol).ToList();
-            array.AddRange(constructorArgumentsTypes);
+            array.AddRange(constructorArgumentsTypes!);
         }
     }
 }

Arch.EventBus/SourceGenerator.cs

@@ -8,15 +8,19 @@
 
 namespace Arch.Bus;
 
+/// <summary>
+/// Query generator.
+/// </summary>
 [Generator]
 public class QueryGenerator : IIncrementalGenerator
 {
     private static EventBus _eventBus;
     private static Hooks _hooks;
 
-    private static Dictionary<ITypeSymbol, (RefKind, IList<ReceivingMethod>)> _eventTypeToReceivingMethods;
-    private static Dictionary<ITypeSymbol, IList<EventHook>> _containingTypeToReceivingMethods;
+    private static Dictionary<ITypeSymbol, (RefKind, IList<ReceivingMethod>)> _eventTypeToReceivingMethods = null!;
+    private static Dictionary<ITypeSymbol, IList<EventHook>> _containingTypeToReceivingMethods = null!;
 
+    /// <inheritdoc cref="IIncrementalGenerator.Initialize"/>
     public void Initialize(IncrementalGeneratorInitializationContext context)
     {
         //if (!Debugger.IsAttached) Debugger.Launch();
@@ -59,7 +63,7 @@ public EventAttribute(int order = 0)
 
 
     /// <summary>
-    ///     Returns a <see cref="MethodDeclarationSyntax"/> if its annocated with a attribute of <see cref="name"/>.
+    ///     Returns a <see cref="MethodDeclarationSyntax"/> if its annotated with an attribute of <paramref name="name"/>.
     /// </summary>
     /// <param name="context">Its <see cref="GeneratorSyntaxContext"/>.</param>
     /// <param name="name">The attributes name.</param>
@@ -97,7 +101,7 @@ private static void MapMethodToEventType(IMethodSymbol methodSymbol)
     {
         var eventType = methodSymbol.Parameters[0];
         var param = methodSymbol.GetAttributes()[0].ConstructorArguments[0];
-        var receivingMethod = new ReceivingMethod{ Static = methodSymbol.IsStatic, MethodSymbol = methodSymbol, Order = (int)param.Value };
+        var receivingMethod = new ReceivingMethod{ Static = methodSymbol.IsStatic, MethodSymbol = methodSymbol, Order = (int)param.Value! };
 
         // Either append or create a new receiving method with a new list.
         if (_eventTypeToReceivingMethods.TryGetValue(eventType.Type, out var tuple))
@@ -189,19 +193,19 @@ private static void Generate(Compilation compilation, ImmutableArray<MethodDecla
         // Init 
         _eventBus.Namespace = "Arch.Bus";
         _eventBus.Methods = new List<Method>(512);
-        _eventTypeToReceivingMethods = new Dictionary<ITypeSymbol, (RefKind, IList<ReceivingMethod>)>(512);
+        _eventTypeToReceivingMethods = new Dictionary<ITypeSymbol, (RefKind, IList<ReceivingMethod>)>(512, SymbolEqualityComparer.Default);
 
         _hooks.Instances = new List<ClassHooks>(512);
-        _containingTypeToReceivingMethods = new Dictionary<ITypeSymbol, IList<EventHook>>(512);
+        _containingTypeToReceivingMethods = new Dictionary<ITypeSymbol, IList<EventHook>>(512, SymbolEqualityComparer.Default);
 
         // Generate Query methods and map them to their classes
         foreach (var methodSyntax in methods)
         {
             var semanticModel = compilation.GetSemanticModel(methodSyntax.SyntaxTree);
             var methodSymbol = ModelExtensions.GetDeclaredSymbol(semanticModel, methodSyntax) as IMethodSymbol;
 
-            MapMethodToEventType(methodSymbol);
-            MapMethodToContainingType(methodSymbol);
+            MapMethodToEventType(methodSymbol!);
+            MapMethodToContainingType(methodSymbol!);
         }
 
         PrepareEventBus();

Arch.Extended.Sample/Game.cs

@@ -27,18 +27,18 @@ namespace Arch.Extended;
 public class Game : Microsoft.Xna.Framework.Game
 {
     // The world and a job scheduler for multithreading
-    private World _world;
-    private JobScheduler _jobScheduler;
+    private World _world = null!;
+    private JobScheduler _jobScheduler = null!;
 
     // Our systems processing entities
-    private System.Group<GameTime> _systems;
-    private DrawSystem _drawSystem;
+    private System.Group<GameTime> _systems = null!;
+    private DrawSystem _drawSystem = null!;
 
     // Monogame stuff
     private GraphicsDeviceManager _graphics;
-    private SpriteBatch _spriteBatch;
-    private Texture2D _texture2D;
-    private Random _random;
+    private SpriteBatch _spriteBatch = null!;
+    private Texture2D _texture2D = null!;
+    private Random _random = null!;
 
     public Game()
     {

Arch.Extended.Sample/Serializer.cs

@@ -15,8 +15,8 @@ public class SpriteSerializer : IJsonFormatter<Sprite>, IMessagePackFormatter<Sp
     /// <summary>
     ///     The <see cref="GraphicsDevice"/> to create <see cref="Texture2D"/>s from. 
     /// </summary>
-    public GraphicsDevice GraphicsDevice { get; set; }
-    
+    public GraphicsDevice GraphicsDevice { get; set; } = null!;
+
     public void Serialize(ref JsonWriter writer, Sprite value, IJsonFormatterResolver formatterResolver)
     {
         writer.WriteBeginObject();

Arch.LowLevel.Tests/UnsafeArrayTest.cs

@@ -54,7 +54,9 @@ public void UnsafeArrayFill()
         var array = new UnsafeArray<int>(35);
         using (array)
         {
+#pragma warning disable CS0728 // Possibly incorrect assignment to local which is the argument to a using or lock statement
             UnsafeArray.Fill(ref array, 8);
+#pragma warning restore CS0728 // Possibly incorrect assignment to local which is the argument to a using or lock statement
 
             for (var i = 0; i < array.Length; i++)
                 That(array[i], Is.EqualTo(8));
@@ -72,8 +74,10 @@ public void UnsafeArrayCopy()
             for (var i = 0; i < src.Length; i++)
                 src[i] = i;
 
+#pragma warning disable CS0728 // Possibly incorrect assignment to local which is the argument to a using or lock statement
             UnsafeArray.Fill(ref dst);
             UnsafeArray.Copy(ref src, 4, ref dst, 1, 4);
+#pragma warning restore CS0728 // Possibly incorrect assignment to local which is the argument to a using or lock statement
 
             Multiple(() =>
             {