Merge pull request #2073 from mezotv/emdash/funky-loops-itch-ev7f8

fix: stop Codex loader when turn completes

Author: arnestrickmann

src/main/core/agent-hooks/notification.ts

@@ -15,6 +15,9 @@ function getNotificationBody(event: AgentEvent): string | null {
   if (event.type === 'notification') {
     const { notificationType } = event.payload;
     if (!notificationType) return null;
+    if (event.providerId === 'codex' && notificationType === 'idle_prompt') {
+      return 'Your agent has finished working';
+    }
     if (isAttentionNotification(notificationType)) {
       return 'Your agent is waiting for input';
     }

src/main/core/conversations/impl/local-conversation.ts

@@ -149,7 +149,15 @@ export class LocalConversationProvider implements ConversationProvider {
     });
 
     const hookActive = port > 0;
-    const useHooksOnly = hookActive && providerDef?.supportsHooks && hooksAvailable;
+    /*
+     * Codex hooks can be skipped by the CLI in some live-session edge cases; keep
+     * the output classifier active as a fallback so the UI can leave "working".
+     */
+    const useHooksOnly =
+      hookActive &&
+      providerDef?.supportsHooks &&
+      hooksAvailable &&
+      conversation.providerId !== 'codex';
 
     if (!useHooksOnly) {
       wireAgentClassifier({

src/renderer/features/tasks/conversations/conversation-manager.ts

@@ -113,6 +113,13 @@ export class ConversationManagerStore implements IDisposable {
       if (event.type === 'notification') {
         const nt = event.payload.notificationType;
         if (!isAttentionNotification(nt)) return;
+        if (event.providerId === 'codex' && nt === 'idle_prompt') {
+          if (conversationStore.status === 'working') {
+            conversationStore.setStatus('completed');
+            soundPlayer.play('task_complete', appFocused);
+          }
+          return;
+        }
         conversationStore.setAwaitingInput(nt);
         soundPlayer.play('needs_attention', appFocused);
         return;