Skip to content

Commit 871a4bf

Browse files
authored
fix: increase test timeout and remove unnecessary hook debugging (#706)
* fix: modify plugin logging to not print * fix: increase test timeout
1 parent cf63d92 commit 871a4bf

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/quality.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ env:
1414
jobs:
1515
quality:
1616
runs-on: ubuntu-latest
17-
timeout-minutes: 90 # TODO: need to reduce this after we figure out our testing strategy.
17+
timeout-minutes: 180
1818
strategy:
1919
matrix:
2020
python-version: ["3.11", "3.12", "3.13"]

test/plugins/_acceptance_sets.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
4. fandf_plugin_set — FIRE_AND_FORGET (background, observe-only)
88
"""
99

10+
import logging
11+
1012
from mellea.plugins import HookType, PluginMode, PluginSet, hook
1113

1214
# ---------------------------------------------------------------------------
@@ -15,6 +17,9 @@
1517

1618
_ALL_HOOK_TYPES = list(HookType)
1719

20+
logger = logging.getLogger("hook-testing")
21+
logger.setLevel(100) # Don't log anything by default.
22+
1823

1924
def _make_hooks(prefix: str, mode: PluginMode):
2025
"""Generate one async hook function per HookType in the given mode."""
@@ -23,7 +28,8 @@ def _make_hooks(prefix: str, mode: PluginMode):
2328

2429
@hook(ht, mode=mode)
2530
async def _hook(payload, ctx, _ht=ht, _prefix=prefix):
26-
print(f"[{_prefix}] {_ht.value}:", payload)
31+
# We still want to do something with these values, but we don't care about the output for now.
32+
logger.debug(f"[{_prefix}] {_ht.value}:", payload)
2733

2834
# Give each closure a unique qualname so the adapter names don't clash.
2935
_hook.__qualname__ = f"{prefix}_{ht.value}"

0 commit comments

Comments
 (0)