fix: silence false-positive context warning in react framework#1009
Open
ajbozarth wants to merge 1 commit intogenerative-computing:mainfrom
Open
fix: silence false-positive context warning in react framework#1009ajbozarth wants to merge 1 commit intogenerative-computing:mainfrom
ajbozarth wants to merge 1 commit intogenerative-computing:mainfrom
Conversation
react() serializes all aact() calls with sequential awaits, so the SimpleContext warning does not apply. Assisted-by: Claude Code Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
react()usesChatContextfor multi-turn history, which triggers the "not using SimpleContext with async requests" warning on every turn. The warning is a false positive here —react()serializes allaact()calls with sequential awaits, so there is no risk of stale context from concurrent access.The
silence_context_type_warningparameter exists precisely for this case; the syncact()wrapper already uses it for the same reason.Testing
Attribution