fix: Remove tests and examples for deprecated models#1012
fix: Remove tests and examples for deprecated models#1012frreiss wants to merge 7 commits intogenerative-computing:mainfrom
Conversation
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
frreiss
changed the title
ajbozarth
left a comment
ajbozarth
left a comment
There was a problem hiding this comment.
A couple of items to fix or clarify before merge.
|
|
||
| This directory contains examples for using Mellea's intrinsic functions - specialized model capabilities accessed through adapters. | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Unresolved merge conflict markers here (lines 5, 51–52). Needs to be resolved before merge.
| non_interactive = true | ||
| disable_error_code = ["empty-body", "import-untyped"] | ||
| python_version = "3.11" | ||
| python_version = "3.12" |
There was a problem hiding this comment.
The mypy python_version bump from 3.11 → 3.12 looks unrelated to the stated scope. If it's intentional, requires-python in pyproject.toml and the CI matrix would need updating too. If it slipped in by accident, please revert.
There was a problem hiding this comment.
The pre-commit scripts would not run for me on Python 3.11. Are you having a different experience?
| return result_json | ||
|
|
||
|
|
||
| def check_context_relevance( |
There was a problem hiding this comment.
check_context_relevance() has been a public API since v0.2.0 and shipped through v0.4.2. Removing it as a hard delete will AttributeError any callers without warning. Should this go through a deprecation cycle (e.g., keep the function but raise DeprecationWarning for one release), or has a decision been made to drop it hard given the underlying adapter is gone?
| _INPUT_ARGS_DIR = _TEST_DATA_DIR / "input_args" | ||
|
|
||
|
|
||
| def _substitute_root( |
There was a problem hiding this comment.
_substitute_root and _dump_output use Sphinx RST :param:/:returns: docstring style. The project follows Google style — Args: / Returns: sections.
2 participants
Misc PR
Type of PR
Description
Testing
Attribution