fix: test model_ids catalog and improve missing-model errors#1299
Open
AngeloDanducci wants to merge 3 commits into
Open
fix: test model_ids catalog and improve missing-model errors#1299AngeloDanducci wants to merge 3 commits into
AngeloDanducci wants to merge 3 commits into
Conversation
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
psschwei
reviewed
Jun 18, 2026
psschwei
left a comment
psschwei
left a comment
Member
There was a problem hiding this comment.
Inline review comments follow. Overall a solid, well-scoped PR — actionable error messages, a correct catalog fix, and a useful drift-guard test. A handful of issues to address before merge.
planetf1
requested changes
Jun 19, 2026
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes #297
Description
test model_ids catalog and improve missing-model errors
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.