feat: (m-decompose) Module Prompt V3#770
Conversation
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
csbobby
changed the title
csbobby
changed the title
|
Updated the modular prompts to adapt the recent llms. |
|
Hi This passes the tests and ready to be reviewed @jakelorocco. |
planetf1
left a comment
planetf1
left a comment
There was a problem hiding this comment.
A few observations — mostly around parsing robustness and test coverage. Also worth checking whether the from e exception-chaining fix applied in _general_instructions.py is needed in any equivalent except blocks in _subtask_constraint_assign.py.
| #MODEL_ID=granite4:latest | ||
|
|
||
| MODEL_ID=qwen2.5:7b | ||
| MODEL_ID=mistral-small3.2:latest # granite4:latest |
There was a problem hiding this comment.
Hardcoded model mistral-small3.2:latest —can we make it variable?
Is the model used documented in the test docs?
How much memory does it need? Is it reasonable on a smaller system (though if it's needed for results, understandable).
There was a problem hiding this comment.
This is a CLI example shell script and the variable MODEL_ID is configurable as an example here. We assume users will have their own scripts but the model is recommended with proper size and capacities.
|
Hi The |
csbobby
force-pushed
the
tagparse
branch
2 times, most recently
from
02555b3 to
08fe688
Compare
315930f
* clean: use default model * add: decomp prompt v3 * upd: enhance general instruction module prompt * upd: enhance subtask constraint assign module prompt * upd: setup the default model * clean: deleted dump results * upd: clean example * upd: setup default model * clean: pre-commit * clean: tmp file * sync: revert to the main * sync: revert to the main * sync: revert to the main * clean: pre-commit format * fix: pre-commit format * mod: pre-commit modifcation * mod: pre-commit clean * mod: pre-commit clean * mod: pre-commit clean * add: enable the v3 * clean: version verify * upd: unify the constraint tag parsing with more item variants * upd: update decompose tests up-to-date * clean: pre-commit * clean: pre-commit module * clean: pre-commit test
3 participants
Module Prompt V3
Description
Implementation Checklist
Protocol Compliance
parts()returns list of constituent parts (Components or CBlocks)format_for_llm()returns TemplateRepresentation or string_parse(computed: ModelOutputThunk)parses model output correctly into the specified Component return typeTesting
tests/components/