fix: restore @pytest.mark.block_network on test_openai_compat#904
Closed
planetf1 wants to merge 1 commit into
Closed
fix: restore @pytest.mark.block_network on test_openai_compat#904planetf1 wants to merge 1 commit into
planetf1 wants to merge 1 commit into
Conversation
Removed in the marker taxonomy audit (PR generative-computing#742 / d3d6040), which doubled CI time from ~17 min to ~35 min. Without the marker, pytest-recording no longer blocks socket access and the OpenAI client waits for a TCP connect timeout (~31 s per call) to the deliberately unreachable URL used by the test. With 17 parameterised cases × 2 calls each, that adds ~18 minutes per matrix job. The test comment already notes "network access is blocked for this test case" — the marker removal was inadvertent. Fixes generative-computing#903 Assisted-by: Claude Code
Collaborator
|
#897 already does this |
Contributor
|
Closing in favor of the other PR. Thank you @planetf1 for investigating. |
Contributor
Author
|
Ah thanks - at least we addressed it - it was a big (inadvertent) change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: restore @pytest.mark.block_network on test_openai_compat
Type of PR
Description
Restores
@pytest.mark.block_networktotest_openai_compatintest/formatters/granite/test_intrinsics_formatters.py.The marker was removed inadvertently during the marker taxonomy audit in #742. Without it,
pytest-recordingno longer blocks socket access and the OpenAI client makes a real TCP connection to the deliberately unreachable URL used by the test (http://example.com:98765/...). The OS connect timeout fires at ~31 s per call; with 17 parameterised cases × 2 calls each, this adds approximately 18 minutes per matrix job, doubling CI time from ~17 min to ~35 min.The test comment already states "Note that network access is blocked for this test case" — confirming the removal was not intentional.
See #903 for the full investigation.
Testing