Skip to content

Commit 99c2b8a

Browse files
claudiamurialdoBeta Bot
authored andcommitted
Cherry pick branch 'genexuslabs:fix/crop-scale-signed-url-filename' into beta
1 parent 07a06b5 commit 99c2b8a

1 file changed

Lines changed: 13 additions & 6 deletions

File tree

dotnet/test/DotNetUnitTest/ImageUtils/ImageUtilTest.cs

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@
88
using GeneXus.Utils;
99
using UnitTesting;
1010
using Xunit;
11+
#if NETCORE
12+
using Image = GeneXus.Drawing.Image;
13+
using GeneXus.Drawing.Imaging;
14+
#else
15+
using Image = System.Drawing.Image;
16+
using System.Drawing.Imaging;
17+
#endif
1118

1219
namespace DotNetCoreUnitTest.ImageUtils
1320
{
@@ -128,17 +135,17 @@ public void TestImageSaveFromSignedUrlDoesNotEmbedQueryString()
128135
string signedUrl = "https://bucket.s3.amazonaws.com/folder/bird-thumbnail.jpg?X-Amz-Expires=86400&X-Amz-Signature=abc123def456&X-Amz-Algorithm=AWS4-HMAC-SHA256";
129136

130137
string destinationPath;
131-
using (System.Drawing.Image image = System.Drawing.Image.FromFile(IMAGE_FILE_PATH))
138+
using (Image image = Image.FromFile(IMAGE_FILE_PATH))
132139
{
133-
destinationPath = GxImageUtil.Save(image, signedUrl, System.Drawing.Imaging.ImageFormat.Jpeg);
140+
destinationPath = GxImageUtil.Save(image, signedUrl, ImageFormat.Jpeg);
134141
}
135142

136143
Assert.False(string.IsNullOrEmpty(destinationPath));
137144
string destinationFileName = Path.GetFileName(destinationPath);
138-
Assert.DoesNotContain("?", destinationFileName);
139-
Assert.DoesNotContain("%3F", destinationFileName);
140-
Assert.DoesNotContain("X-Amz-Expires", destinationFileName);
141-
Assert.DoesNotContain("X-Amz-Signature", destinationFileName);
145+
Assert.DoesNotContain("?", destinationFileName, StringComparison.Ordinal);
146+
Assert.DoesNotContain("%3F", destinationFileName, StringComparison.Ordinal);
147+
Assert.DoesNotContain("X-Amz-Expires", destinationFileName, StringComparison.Ordinal);
148+
Assert.DoesNotContain("X-Amz-Signature", destinationFileName, StringComparison.Ordinal);
142149

143150
Assert.Equal(IMAGE_HEIGHT, GxImageUtil.GetImageHeight(destinationPath));
144151
Assert.Equal(IMAGE_WIDTH, GxImageUtil.GetImageWidth(destinationPath));

0 commit comments

Comments
 (0)