Skip to content

New SAML 2.0 implementation for GAM#1114

Merged
sgrampone merged 29 commits into
masterfrom
gamsaml20_eo
Jul 31, 2025
Merged

New SAML 2.0 implementation for GAM#1114
sgrampone merged 29 commits into
masterfrom
gamsaml20_eo

Conversation

@sgrampone

@sgrampone sgrampone commented Mar 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

issue:203820

This new implementation solves:

  • Diverse dependency issues that previous connector had by avoiding specific SAML libraries and using generalist libraries more commonly used and with constant maintenance. It also reduce the number of dependencies included on the dependency tree.
  • It works with JavaEE and JakartaEE by being an External Objects, it delegates the management of servlets to GeneXus Java generator.
  • Create an implementation to Net (ex Net Core). It previously didn't exists.
  • Provide a more practical way to load keys, keystores and certificates for clients who use cloud infrastructure. It does it by loading keys, keystores and certificates using Base64 encoding.
  • Load user's roles provided by the IdP on Login.

#GXSEC

@sgrampone sgrampone temporarily deployed to external-storage-tests March 12, 2025 17:50 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta failed, 1 conflicted file in commit f48b321
  • dotnet/DotNetStandardClasses.sln

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Mar 12, 2025
@genexusbot

genexusbot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor
Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Mar 12, 2025
@sgrampone sgrampone temporarily deployed to external-storage-tests March 12, 2025 18:36 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta success

@sgrampone sgrampone temporarily deployed to external-storage-tests March 17, 2025 15:10 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta failed, 1 conflicted file in commit 8559bca
  • dotnet/DotNetStandardClasses.sln

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Mar 17, 2025
@genexusbot

genexusbot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor
Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Mar 17, 2025
@sgrampone sgrampone temporarily deployed to external-storage-tests March 17, 2025 17:01 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta failed, 1 conflicted file in commit 07bb27f
  • dotnet/src/extensions/gam/src/DotNet/GamSaml20Net/GamSaml20Net.csproj

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Mar 17, 2025
@genexusbot

genexusbot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor
Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Mar 17, 2025
@sgrampone sgrampone temporarily deployed to external-storage-tests March 17, 2025 17:35 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta success

@sgrampone sgrampone temporarily deployed to external-storage-tests March 18, 2025 13:56 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta failed, 1 conflicted file in commit b309b9e
  • dotnet/src/extensions/gam/src/DotNet/GamSaml20Net/GamSaml20Net.csproj

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Mar 18, 2025
@genexusbot

genexusbot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor
Manual cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests July 30, 2025 20:04 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo temporarily deployed to kafka-integration-tests July 30, 2025 20:04 — with GitHub Actions Inactive
Define the GX_SIGNED_ASSEMBLY constant to determine at build time whe…
bd7fec8 
…ther the assembly is strong-named (has a public key). Based on this, set the appropriate InternalsVisibleTo attribute in AssemblyInfo.cs used for UnitTests.
@claudiamurialdo claudiamurialdo temporarily deployed to kafka-integration-tests July 31, 2025 12:28 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests July 31, 2025 12:28 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta success

The GamSaml20.csproj project does not require a reference to StrongNa…
2aa4d32 
…mer, as it does not reference any unsigned packages.

Remove gamkey.snk and sign the GAM assemblies using the same .snk file as the rest of the assemblies for consistency.

Enable SignAssembly only when an AssemblyOriginatorKeyFile is present. Otherwise, tests fail on GitHub Actions when the project is built without a .snk file.
@claudiamurialdo claudiamurialdo temporarily deployed to kafka-integration-tests July 31, 2025 13:43 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests July 31, 2025 13:43 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta failed, 1 conflicted file in commit 2aa4d32
  • dotnet/src/extensions/gam/test/DotNetFramework/GamTest/GamTest.csproj

@genexusbot genexusbot added the conflict Conflict merging to beta branch label Jul 31, 2025
@genexusbot

genexusbot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor
Manual cherry pick to beta success

@genexusbot genexusbot removed the conflict Conflict merging to beta branch label Jul 31, 2025
Remove unnecessary reference to StrongNamer.
d35d2b8 
Update GamUtils to reference StrongNamer only when assembly signing is enabled, preventing issues with unit tests and InternalsVisibleTo usage.
@claudiamurialdo claudiamurialdo temporarily deployed to kafka-integration-tests July 31, 2025 14:00 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests July 31, 2025 14:00 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta success

@claudiamurialdo claudiamurialdo temporarily deployed to external-storage-tests July 31, 2025 14:30 — with GitHub Actions Inactive
@claudiamurialdo claudiamurialdo temporarily deployed to kafka-integration-tests July 31, 2025 14:30 — with GitHub Actions Inactive
@genexusbot

genexusbot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor
Cherry pick to beta success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@claudiamurialdo claudiamurialdo claudiamurialdo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgrampone @genexusbot @claudiamurialdo