Migrate solution files from .sln to .slnx#1262
Merged
Merged
Conversation
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit f28ec9e
|
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Collaborator
Manual cherry pick to beta success |
Collaborator
…der in output path With TargetFrameworks (plural), MSBuild outputs to bin/Release/net10.0/ even for a single TFM, causing getBLOB_PATH() base path mismatch in GXDBFilePathTest. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Collaborator
Cherry pick to beta success |
fedeazzato
previously approved these changes
Mar 27, 2026
|
|
||
| - name: Build temporary solution | ||
| run: dotnet build dotnet\CodeqlSolution.sln --framework net8.0 | ||
| run: dotnet build dotnet\CodeqlSolution.slnx --framework net8.0 |
Member
There was a problem hiding this comment.
Shouldn't the --framework argument be updated to net10.0?
| dotnet new sln --format sln --name $TempSolution --output dotnet --force | ||
| dotnet msbuild dotnet\DotNetStandardClasses.sln /t:DumpProjects -p:DumpSolutionName=$TempSolution /m:1 -p:DumpSolutionTargetFrameworkDefault=net8 | ||
| dotnet new sln --name $TempSolution --output dotnet --force | ||
| dotnet msbuild dotnet\DotNetStandardClasses.slnx /t:DumpProjects -p:DumpSolutionName=$TempSolution /m:1 -p:DumpSolutionTargetFrameworkDefault=net8 |
Member
There was a problem hiding this comment.
Shouldn't the -p:DumpSolutionTargetFrameworkDefault be updated to net10?
Collaborator
Author
There was a problem hiding this comment.
All your suggestions have been applied. Thanks for the feedback
| run: | | ||
| dotnet new sln --name $SolutionFileName --output dotnet --force | ||
| dotnet msbuild dotnet/DotNetStandardClasses.sln /t:DumpProjectsAndCoreTests -p:DumpSolutionName=$SolutionFileName -p:DumpSolutionExtension=slnx /m:1 -p:DumpSolutionTargetFrameworkDefault=net8 | ||
| dotnet msbuild dotnet/DotNetStandardClasses.slnx /t:DumpProjectsAndCoreTests -p:DumpSolutionName=$SolutionFileName -p:DumpSolutionExtension=slnx /m:1 -p:DumpSolutionTargetFrameworkDefault=net8 |
Member
There was a problem hiding this comment.
Shouldn't the -p:DumpSolutionTargetFrameworkDefault be updated to net10?
| @@ -65,7 +65,7 @@ jobs: | |||
| - name: Create temporary solution with .NET 8 projects | |||
Member
There was a problem hiding this comment.
There's a message here referring to .NET 8
| <DumpSolutionName>TempSolution</DumpSolutionName> | ||
| <DumpSolutionExtension>sln</DumpSolutionExtension> | ||
| <DumpSolutionExtension>slnx</DumpSolutionExtension> | ||
| <DumpSolutionTargetFrameworkDefault>net8</DumpSolutionTargetFrameworkDefault> |
Member
There was a problem hiding this comment.
Shouldn't this prop be updated to net10?
| # How to build | ||
|
|
||
| ## Requirements | ||
| - Visual Studio 2022 (17.8 or higher). |
Member
There was a problem hiding this comment.
VS versions compatible with slnx are 2025 (17.14 or higher), but recommended 2026.
| - ```dotnet msbuild /p:TF=net8.0 /p:DeployDirectory=C:\KB\NetModel\web\bin DotNetStandardClasses.sln``` | ||
| - ```dotnet msbuild /p:TF=net10.0 /p:DeployDirectory=C:\KB\NetModel\web\bin DotNetStandardClasses.slnx``` | ||
|
|
||
| It compiles the solution and copies all the .NET 8 assemblies to the folder C:\KB\NetModel\web\bin. |
Member
There was a problem hiding this comment.
There's a message with a reference to .NET 8
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Collaborator
Cherry pick to beta success |
fedeazzato
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to .slnx solution format and update all references
Issue:208221