Apply Timeout to HttpClient instances created with authentication#1277
Merged
Conversation
When AddAuthentication() is called, GxHttpClient passes a non-empty authCollection to GetHttpClientInstance, so CacheableInstance returns false and the non-cached branch builds a fresh HttpClient. That branch never set client.Timeout, leaving the default 100s and silently ignoring the user-configured Timeout property. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
AlejandroP
approved these changes
May 7, 2026
claudiamurialdo
added a commit
that referenced
this pull request
May 7, 2026
) When AddAuthentication() is called, GxHttpClient passes a non-empty authCollection to GetHttpClientInstance, so CacheableInstance returns false and the non-cached branch builds a fresh HttpClient. That branch never set client.Timeout, leaving the default 100s and silently ignoring the user-configured Timeout property. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit bb1a5c6) # Conflicts: # dotnet/src/dotnetframework/GxClasses/Domain/GxHttpClient.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When AddAuthentication() is called, GxHttpClient passes a non-empty authCollection to GetHttpClientInstance, so CacheableInstance returns false and the non-cached branch builds a fresh HttpClient. That branch never set client.Timeout, leaving the default 100s and silently ignoring the user-configured Timeout property.
Issue:208609