Treat null/missing CmpContext and IsMasterPage as equivalent in GetGxObject#1284
Merged
claudiamurialdo merged 1 commit intoJun 9, 2026
Merged
Conversation
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Contributor
Cherry pick to beta success |
…Object HttpAjaxContext.GetGxObject(JArray, CmpContext, IsMasterPage) iterates the array looking for an entry that matches the (CmpContext, IsMasterPage) pair. The previous lookup called obj['CmpContext'].ToString() and obj['IsMasterPage'].ToString() directly — when the array entry didn't carry those keys, the indexer returned null and ToString() threw NullReferenceException, which fell into the catch and made the function return null, breaking the callers (ajax_rsp_assign_attri and similar). Make the comparison null-safe and treat 'missing/null/empty' as semantically equivalent to the default value: - CmpContext: a missing/empty entry matches a null-or-empty parameter. - IsMasterPage: a missing/empty entry matches IsMasterPage == false (default for bool). Comparison is case-insensitive against IsMasterPage.ToString(). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
claudiamurialdo
force-pushed
the
fix/getgxobject-cmpcontext-nullempty-match
branch
from
87ef872 to
883f4bb
Compare
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Contributor
Cherry pick to beta failed, 1 conflicted file in commit 883f4bb
|
Contributor
Manual cherry pick to beta success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the comparison null-safe and treat 'missing/null/empty' as semantically equivalent to the default value:
Issue:208727