Fix flaky GXDBFilePathTest by deriving base through ResolveUri (#1292)#1295
Merged
claudiamurialdo merged 1 commit intoJun 9, 2026
Merged
Conversation
The assertion compared the resolved malicious path against Preferences.getBLOB_PATH() directly and used `new Uri(newFileName)`, which throws "Invalid URI: The format of the URI could not be determined" when ResolveUri returns a relative path. This happened intermittently: when a prior test in the same process sets GxContext.IsHttpContext = true (via GxNetCoreStartup), the cached blobPath gets rooted differently while ResolveUri can still reresolve paths against the current working directory, making the StartsWith check fail (or new Uri throw) even when no real traversal occurred. Use Uri.TryCreate(UriKind.Absolute) with a fallback so the resolution no longer throws, and derive the comparison base from ResolveUri of a known-safe filename, so both sides go through the same code path and share any environment-dependent rooting. The security invariant is unchanged: resolved malicious inputs must stay inside the blob/multimedia directory. Backport of the test fix from #1272. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion compared the resolved malicious path against Preferences.getBLOB_PATH() directly and used
new Uri(newFileName), which throws "Invalid URI: The format of the URI could not be determined" when ResolveUri returns a relative path.This happened intermittently: when a prior test in the same process sets GxContext.IsHttpContext = true (via GxNetCoreStartup), the cached blobPath gets rooted differently while ResolveUri can still reresolve paths against the current working directory, making the StartsWith check fail (or new Uri throw) even when no real traversal occurred.
Use Uri.TryCreate(UriKind.Absolute) with a fallback so the resolution no longer throws, and derive the comparison base from ResolveUri of a known-safe filename, so both sides go through the same code path and share any environment-dependent rooting. The security invariant is unchanged: resolved malicious inputs must stay inside the blob/multimedia directory.
Backport of the test fix from #1272.