Skip to content

Fix flaky GXDBFilePathTest by deriving base through ResolveUri (#1292) #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claudiamurialdo merged 1 commit into from
Jun 9, 2026
Merged

Fix flaky GXDBFilePathTest by deriving base through ResolveUri (#1292) #1295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions dotnet/test/DotNetUnitTest/FileIO/FileIOTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,20 +91,21 @@ public void GXDBFilePathTest()
"content%5c..%5c..%5c..%5cdocument.aspx","content%255c%252e%252e%255c%252e%252e%255c%252e%252e%255cdocument.aspx","content%255c..%255c..%255c..%255cdocument.aspx",
"content%c0%af..%c0%af..%c0%af..%c0%afdocument.aspx","content%c1%9c..%c1%9c..%c1%9c..%c1%9cdocument.aspx"};

string safeResolved = GXDbFile.ResolveUri($"{GXDbFile.Scheme}:safe.txt", false);
string safeResolvedPath = Uri.TryCreate(safeResolved, UriKind.Absolute, out Uri safeUri) && safeUri.IsFile
? safeUri.LocalPath
: safeResolved;
string fullBase = Path.GetDirectoryName(Path.GetFullPath(safeResolvedPath)) + Path.DirectorySeparatorChar;

foreach (string fileName in filesName)
{
string newFileName = GXDbFile.ResolveUri($"{GXDbFile.Scheme}:{fileName}", false);
string baseDir = Preferences.getBLOB_PATH();
try
{
bool isOK = new Uri(newFileName).LocalPath.StartsWith(Path.GetFullPath(baseDir), StringComparison.OrdinalIgnoreCase);
Assert.True(isOK);
}
catch (Exception ex)
{

Assert.True(false, $"FileName:{newFileName} Error:{ex.Message} ExternalProvider:{ServiceFactory.GetExternalProvider()?.GetType().FullName} fileName:{fileName}");
}
string resolvedPath = Uri.TryCreate(newFileName, UriKind.Absolute, out Uri parsedUri) && parsedUri.IsFile
? parsedUri.LocalPath
: newFileName;
string fullResolved = Path.GetFullPath(resolvedPath);
bool isOK = fullResolved.StartsWith(fullBase, StringComparison.OrdinalIgnoreCase);
Assert.True(isOK, $"Path traversal detected: resolved '{fullResolved}' is outside base '{fullBase}' for input '{fileName}'");
}
}

Expand Down
Loading