Fix release pipeline: nuspec path, snupkg, auto-pack noise, --no-build

The previous workflow run failed with NU5008 because /p:NuspecFile=..\..\GXOData.Client.nuspec
on the command line did not resolve correctly relative to the GXOData.Client.All csproj
during `dotnet pack`.

- src/GXOdata.Client.All/GXOData.Client.All.csproj:
  * Move NuspecFile to the csproj using $(MSBuildThisFileDirectory) so the path is
    absolute and unambiguous. Also set NuspecBasePath so file entries in the nuspec
    resolve from the repo root.
  * Set IncludeSymbols=false. The nuspec doesn't enumerate source/symbol files, so
    pack was failing with NU5005 trying to build the snupkg.
  * Set GeneratePackageOnBuild=false (overrides upstream Directory.Build.props),
    otherwise build would ship an extra default-versioned GXOData.Client.All.1.0.0.nupkg
    alongside the proper GeneXus.Odata.Client.*.nupkg.

- .github/workflows/build.yml:
  * Drop /p:NuspecFile=..\..\:NuspecFile from the Package step (now in csproj).
  * Add --no-build to the Package step so pack reuses the msbuild artifacts instead
    of doing its own incremental build, which was hitting transient CS0518 on
    netstandard2.0.
  * Filter Sign and Publish to GeneXus.Odata.Client.*.nupkg only. Upstream csprojs
    (Simple.OData.Client.Core, V3.Adapter, V4.Adapter) auto-pack with their
    original IDs and default 1.0.0 version — we don't want to sign or publish those.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: claudiamurialdo

.github/workflows/build.yml

@@ -72,7 +72,7 @@ jobs:
       run: dotnet msbuild $Env:SolutionFile -p:Configuration=$Env:Configuration /t:Clean,Build
 
     - name: Package
-      run: dotnet pack $Env:SolutionFile --output $Env:PackageFolder /p:NuspecFile=..\..\$Env:NuspecFile
+      run: dotnet pack $Env:SolutionFile --no-build --output $Env:PackageFolder
 
     - name: Sign
       if: github.base_ref == ''
@@ -97,7 +97,11 @@ jobs:
             -Body $body).access_token
         Write-Host "::add-mask::$token"
 
-        Get-ChildItem ".\*.nupkg" -Recurse | ForEach-Object {
+        # Only operate on the GeneXus meta-package. Upstream csprojs auto-pack with
+        # their own IDs (Simple.OData.Client.*) which we don't want to sign or publish.
+        Get-ChildItem ".\*.nupkg" -Recurse |
+          Where-Object { $_.Name -like "GeneXus.Odata.Client.*.nupkg" } |
+          ForEach-Object {
           dotnet tool run NuGetKeyVaultSignTool sign $_.FullName `
             -kvu $Env:VAULT_URL `
             -kvc $Env:CERT_NAME `
@@ -129,7 +133,11 @@ jobs:
       run: |
        $IsPrerelease = "${{ github.ref }}".StartsWith("refs/heads/")
 
-        Get-ChildItem ".\*.nupkg" -Recurse | ForEach-Object {
+        # Only operate on the GeneXus meta-package. Upstream csprojs auto-pack with
+        # their own IDs (Simple.OData.Client.*) which we don't want to sign or publish.
+        Get-ChildItem ".\*.nupkg" -Recurse |
+          Where-Object { $_.Name -like "GeneXus.Odata.Client.*.nupkg" } |
+          ForEach-Object {
           $PushToGitHubArgs = @("nuget", "push", $_.FullName, "--source", $Env:GPRFeedURL, "--api-key", "${{ secrets.SECURE_TOKEN }}")
           $PushToNugetArgs  = @("nuget", "push", $_.FullName, "--source", $Env:NuGetFeedURL, "--api-key", "${{ secrets.NUGET_ORG_TOKEN }}")
           $PushToAzureArgs  = @("nuget", "push", $_.FullName, "--source", $Env:AZURE_ARTIFACTS_URL, "--api-key", "DUMMY-KEY")

src/GXOdata.Client.All/GXOData.Client.All.csproj

@@ -9,6 +9,17 @@
     <DocumentationFile>..\GXOData.Client.All\GXOData.Client.All.xml</DocumentationFile>
     <DefineConstants>TRACE</DefineConstants>
     <NoWarn>1701;1702;1705;1591;1712;1573</NoWarn>
+    <!-- Absolute path to the nuspec living at the repo root. Passing this relative
+         via -p:NuspecFile=..\..\GXOData.Client.nuspec on the command line did not
+         resolve correctly inside `dotnet pack`. -->
+    <NuspecFile>$(MSBuildThisFileDirectory)..\..\GXOData.Client.nuspec</NuspecFile>
+    <NuspecBasePath>$(MSBuildThisFileDirectory)..\..\</NuspecBasePath>
+    <!-- The nuspec doesn't enumerate source/symbol files, so let pack skip the snupkg. -->
+    <IncludeSymbols>false</IncludeSymbols>
+    <!-- The release nupkg is produced by the explicit `dotnet pack` step in the workflow.
+         Suppress the auto-pack on build that upstream's Directory.Build.props turns on,
+         otherwise we ship an extra (default-versioned) GXOData.Client.All.1.0.0.nupkg. -->
+    <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)'=='Debug'">