Add net462 target to GXOData.Client.All for .NET Framework consumers#11
Merged
Merged
Conversation
The 6.0-GX line resynced with upstream simple-odata-client, which dropped the net4x target and now ships only net8.0/net7.0/netstandard2.0. As a result, .NET Framework consumers (notably GeneXus-generated KBs built with the legacy v4.0.30319 MSBuild) resolve the netstandard2.0 asset, whose public types (e.g. ODataEntry) live in a netstandard-targeted assembly. Those projects do not pull in the netstandard.dll facade automatically, so the C# compiler cannot resolve System.Object for those types and fails with CS0012, cascading into CS1593 overload-resolution errors against the GXODataClient query delegates. Re-add a native .NET Framework asset so NuGet/the GeneXus build prefer it over netstandard2.0 on net46x+ projects: - GXOData.Client.All.csproj: add net462 to TargetFrameworks, plus a net462-only ItemGroup. net462 lacks types the netstandard2.0 sources assume: reference System.Net.Http (4.3.4, matching DynServiceOData), add System.ValueTuple (4.5.0, in-box only from net47), and import System.Net.Http explicitly since the SDK adds it to ImplicitUsings only for .NET/.NET Standard TFMs, not .NET Framework. - GXOData.Client.nuspec: add the net462 dependency group and lib\net462 file entries. - Bump AssemblyVersion 6.0.2.0 -> 6.0.3.0 so a new package is published. Verified: net462 builds clean, the full solution builds, and dotnet pack produces a nupkg containing lib/net462/GXOData.Client.All.dll. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6.0-GX line resynced with upstream simple-odata-client, which dropped the net4x target and now ships only net8.0/net7.0/netstandard2.0. As a result, .NET Framework consumers (notably GeneXus-generated KBs built with the legacy v4.0.30319 MSBuild) resolve the netstandard2.0 asset, whose public types (e.g. ODataEntry) live in a netstandard-targeted assembly. Those projects do not pull in the netstandard.dll facade automatically, so the C# compiler cannot resolve System.Object for those types and fails with CS0012, cascading into CS1593 overload-resolution errors against the GXODataClient query delegates.
Re-add a native .NET Framework asset so NuGet/the GeneXus build prefer it over netstandard2.0 on net46x+ projects:
Verified: net462 builds clean, the full solution builds, and dotnet pack produces a nupkg containing lib/net462/GXOData.Client.All.dll.
Issue:208663