Pin ODataLib versions so the shipped GXOData binary is deterministic (6.0.4)#12
Merged
Merged
Conversation
…(6.0.4) The package referenced Microsoft.Data.OData "[5.*, 6.0.0)" and Microsoft.OData.Core "[7.*, 8.0.0)" — floating lower bounds that bind the redistributed GXOData.Client.All binary to whatever patch was latest at build time. 6.0.3 ended up bound to Microsoft.Data.OData/Edm 5.8.5.0, while consumers pinning 5.8.4 only deploy 5.8.4.0, so Assembly.GetTypes() on the merged adapter threw ReflectionTypeLoadException. Pin both to fixed versions (Microsoft.Data.OData 5.8.4, Microsoft.OData.Core 7.4.4), centralized as MSBuild properties in src/Directory.Build.props as the single source of truth across the V3/V4 adapters and the merged GXOData.Client.All. Restore now resolves 5.8.4 / 7.4.4, matching consumers. Bump AssemblyVersion 6.0.3.0 -> 6.0.4.0 so the fixed binary ships as a new package version. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package referenced Microsoft.Data.OData "[5., 6.0.0)" and Microsoft.OData.Core "[7., 8.0.0)" — floating lower bounds that bind the redistributed GXOData.Client.All binary to whatever patch was latest at build time. 6.0.3 ended up bound to Microsoft.Data.OData/Edm 5.8.5.0, while consumers pinning 5.8.4 only deploy 5.8.4.0, so Assembly.GetTypes() on the merged adapter threw ReflectionTypeLoadException.
Pin both to fixed versions (Microsoft.Data.OData 5.8.4, Microsoft.OData.Core 7.4.4), centralized as MSBuild properties in src/Directory.Build.props as the single source of truth across the V3/V4 adapters and the merged GXOData.Client.All. Restore now resolves 5.8.4 / 7.4.4, matching consumers. Bump AssemblyVersion 6.0.3.0 -> 6.0.4.0 so the fixed binary ships as a new package version.
Issue:208663